Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 13896009: Remove landing page from history when redirecting to NTP so that the back-button will work as expec… (Closed)

Created:
7 years, 8 months ago by bcwhite
Modified:
7 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Remove landing page from history when redirecting to NTP so that the back-button will work as expected. BUG=180145 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195061

Patch Set 1 #

Patch Set 2 : removed test since required modules aren't available on all builds #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -0 lines) Patch
M chrome/browser/ui/sync/one_click_signin_helper.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/sync/one_click_signin_helper.cc View 3 chunks +51 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
bcwhite
I tried to write a test but the NavigationController is not testable and so must ...
7 years, 8 months ago (2013-04-18 20:26:17 UTC) #1
Roger Tawa OOO till Jul 10th
lgtm Do you need the two Observe(NULL) calls, since the dtor does that anyway?
7 years, 8 months ago (2013-04-18 20:50:52 UTC) #2
bcwhite
> Do you need the two Observe(NULL) calls, since the dtor does that anyway? I've ...
7 years, 8 months ago (2013-04-18 21:56:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bcwhite@chromium.org/13896009/4001
7 years, 8 months ago (2013-04-18 21:56:41 UTC) #4
commit-bot: I haz the power
7 years, 8 months ago (2013-04-19 03:18:25 UTC) #5
Message was sent while issue was closed.
Change committed as 195061

Powered by Google App Engine
This is Rietveld 408576698