filemanager: Add a browsertest for the sidebar item "Shared with Me".

filemanager: Add a browsertest for the sidebar item "Shared with Me".

This CL also adds "shared_with_me" parameter to FakeDriveService to create an entry with "shared-with-me" label.

BUG=223051
TEST=browser_tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194970

[Haruki Sato, 2013-04-18 07:11:34]

Change based on 14258002, which is in CQ.

[mtomasz, 2013-04-18 09:46:03]

Looks good, just minor style comments.

https://codereview.chromium.org/13896006/diff/6001/chrome/browser/chromeos/ex...
File chrome/browser/chromeos/extensions/file_manager/file_manager_browsertest.cc
(right):

https://codereview.chromium.org/13896006/diff/6001/chrome/browser/chromeos/ex...
chrome/browser/chromeos/extensions/file_manager/file_manager_browsertest.cc:513:
CreateTestFileWithMimeType(name, "text/plain", length, false,
Add a comment what is this false or use enum.

https://codereview.chromium.org/13896006/diff/6001/chrome/browser/chromeos/ex...
chrome/browser/chromeos/extensions/file_manager/file_manager_browsertest.cc:521:
bool sharedWithMe,
sharedWithMe -> shared_with_me here and in other places.

https://codereview.chromium.org/13896006/diff/6001/chrome/browser/google_apis...
File chrome/browser/google_apis/fake_drive_service.cc (right):

https://codereview.chromium.org/13896006/diff/6001/chrome/browser/google_apis...
chrome/browser/google_apis/fake_drive_service.cc:1202: base::DictionaryValue*
sharedWithMeLabel = new base::DictionaryValue;
sharedWithMeLabel -> shared_with_me_label in C++.

https://codereview.chromium.org/13896006/diff/6001/chrome/browser/google_apis...
chrome/browser/google_apis/fake_drive_service.cc:1204:
sharedWithMeLabel->SetString("scheme",
"http://schemas.google.com/g/2005/labels");
Exceeds > 80 characters? Please check.

https://codereview.chromium.org/13896006/diff/6001/chrome/browser/google_apis...
chrome/browser/google_apis/fake_drive_service.cc:1206:
"http://schemas.google.com/g/2005/labels#shared");
Indentation is off.

https://codereview.chromium.org/13896006/diff/6001/chrome/browser/google_apis...
File chrome/browser/google_apis/fake_drive_service_unittest.cc (right):

https://codereview.chromium.org/13896006/diff/6001/chrome/browser/google_apis...
chrome/browser/google_apis/fake_drive_service_unittest.cc:1811: false,
Please comment this argument here and in other places, or enum.

https://codereview.chromium.org/13896006/diff/6001/chrome/test/data/extension...
File chrome/test/data/extensions/api_test/file_manager_browsertest/test_cases.js
(right):

https://codereview.chromium.org/13896006/diff/6001/chrome/test/data/extension...
chrome/test/data/extensions/api_test/file_manager_browsertest/test_cases.js:253:
* icon, and checks contenets of the file list. Only the entries labeled with
contenets -> contents

https://codereview.chromium.org/13896006/diff/6001/chrome/test/data/extension...
chrome/test/data/extensions/api_test/file_manager_browsertest/test_cases.js:257:
console.log(' haruki DEBUG: openSidebarSharedWithMe');
Remove debugs after they are not needed.

[hashimoto, 2013-04-18 10:21:17]

+hidehiko

[Haruki Sato, 2013-04-18 11:33:44]

https://codereview.chromium.org/13896006/diff/6001/chrome/browser/chromeos/ex...
File chrome/browser/chromeos/extensions/file_manager/file_manager_browsertest.cc
(right):

https://codereview.chromium.org/13896006/diff/6001/chrome/browser/chromeos/ex...
chrome/browser/chromeos/extensions/file_manager/file_manager_browsertest.cc:513:
CreateTestFileWithMimeType(name, "text/plain", length, false,
On 2013/04/18 09:46:03, mtomasz wrote:
> Add a comment what is this false or use enum.

Done.

https://codereview.chromium.org/13896006/diff/6001/chrome/browser/chromeos/ex...
chrome/browser/chromeos/extensions/file_manager/file_manager_browsertest.cc:521:
bool sharedWithMe,
On 2013/04/18 09:46:03, mtomasz wrote:
> sharedWithMe -> shared_with_me here and in other places.

Done.

https://codereview.chromium.org/13896006/diff/6001/chrome/browser/google_apis...
File chrome/browser/google_apis/fake_drive_service.cc (right):

https://codereview.chromium.org/13896006/diff/6001/chrome/browser/google_apis...
chrome/browser/google_apis/fake_drive_service.cc:1202: base::DictionaryValue*
sharedWithMeLabel = new base::DictionaryValue;
On 2013/04/18 09:46:03, mtomasz wrote:
> sharedWithMeLabel -> shared_with_me_label in C++.

Done. Thanks.

https://codereview.chromium.org/13896006/diff/6001/chrome/browser/google_apis...
chrome/browser/google_apis/fake_drive_service.cc:1204:
sharedWithMeLabel->SetString("scheme",
"http://schemas.google.com/g/2005/labels");
On 2013/04/18 09:46:03, mtomasz wrote:
> Exceeds > 80 characters? Please check.

Done.

https://codereview.chromium.org/13896006/diff/6001/chrome/browser/google_apis...
chrome/browser/google_apis/fake_drive_service.cc:1206:
"http://schemas.google.com/g/2005/labels#shared");
On 2013/04/18 09:46:03, mtomasz wrote:
> Indentation is off.

Done.

https://codereview.chromium.org/13896006/diff/6001/chrome/browser/google_apis...
File chrome/browser/google_apis/fake_drive_service_unittest.cc (right):

https://codereview.chromium.org/13896006/diff/6001/chrome/browser/google_apis...
chrome/browser/google_apis/fake_drive_service_unittest.cc:1811: false,
On 2013/04/18 09:46:03, mtomasz wrote:
> Please comment this argument here and in other places, or enum.

Done.

https://codereview.chromium.org/13896006/diff/6001/chrome/test/data/extension...
File chrome/test/data/extensions/api_test/file_manager_browsertest/test_cases.js
(right):

https://codereview.chromium.org/13896006/diff/6001/chrome/test/data/extension...
chrome/test/data/extensions/api_test/file_manager_browsertest/test_cases.js:253:
* icon, and checks contenets of the file list. Only the entries labeled with
On 2013/04/18 09:46:03, mtomasz wrote:
> contenets -> contents

Done. Thanks.

https://codereview.chromium.org/13896006/diff/6001/chrome/test/data/extension...
chrome/test/data/extensions/api_test/file_manager_browsertest/test_cases.js:257:
console.log(' haruki DEBUG: openSidebarSharedWithMe');
On 2013/04/18 09:46:03, mtomasz wrote:
> Remove debugs after they are not needed.

Done. Thanks!

[mtomasz, 2013-04-18 12:07:23]

lgtm!

[hashimoto, 2013-04-18 12:41:48]

lgtm with a nit.

https://chromiumcodereview.appspot.com/13896006/diff/19002/chrome/browser/goo...
File chrome/browser/google_apis/fake_drive_service_unittest.cc (right):

https://chromiumcodereview.appspot.com/13896006/diff/19002/chrome/browser/goo...
chrome/browser/google_apis/fake_drive_service_unittest.cc:1946: EXPECT_EQ(1U,
resource_entry->labels().size());
ASSERT_EQ here.
The next line results in crash if resource_entry->labels().size() == 0.

[Haruki Sato, 2013-04-18 12:49:26]

https://chromiumcodereview.appspot.com/13896006/diff/19002/chrome/browser/goo...
File chrome/browser/google_apis/fake_drive_service_unittest.cc (right):

https://chromiumcodereview.appspot.com/13896006/diff/19002/chrome/browser/goo...
chrome/browser/google_apis/fake_drive_service_unittest.cc:1946: EXPECT_EQ(1U,
resource_entry->labels().size());
On 2013/04/18 12:41:49, hashimoto wrote:
> ASSERT_EQ here.
> The next line results in crash if resource_entry->labels().size() == 0.
Done. Good catch! Thanks.

[commit-bot: I haz the power, 2013-04-18 12:49:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/haruki@chromium.org/13896006/15010

[commit-bot: I haz the power, 2013-04-18 14:40:20]

Retried try job too often on linux_chromeos for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-04-18 15:48:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/haruki@chromium.org/13896006/30001

[commit-bot: I haz the power, 2013-04-18 18:23:16]

Change committed as 194970