DescriptionTweak Views Omnibox/Textfield; re-enable OmniboxViewTest.SelectAllOnClick.
Update test expectations for OmniboxViewTest.SelectAllOnClick:
(CrOS used to show/retain unfocused (grey highlight) Omnibox selections)
(My http://crrev.com/183239 made it save/restore selections like Windows)
Don't expect unfocused selections; check that clicking anew selects all.
Move the base omnibox click offset over to the right a little.
(fixes the test for OmniboxViewWin's slightly different hit-test area)
Enable previously USE_AURA-limited code on all TOOLKIT_VIEWS.
Update NativeTextfieldViews::OnMouseDragged to only handle left-click.
(it was incorrectly and incompletely handling right- and middle-drag)
Make NativeTextfieldViews::HandleMousePressEvent focus on right-click.
(it was selecting all and showing the context menu without taking focus)
Use ui_test_utils::IsViewFocused() instead of GetFocusView()->HasFocus();
Inline the last remaining GetFocusView call; some refactoring.
BUG=128556, 139069
TEST=None; OmniboxViewTest.SelectAllOnClick passes.
R=derat@chromium.org,sky@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193404
Patch Set 1 #Patch Set 2 : Inline the last use of GetFocusView; cleanup. #Patch Set 3 : Remove extra click causing hangs on Win; rename ClickOmnibox. #Patch Set 4 : Fix click location; enable for TOOLKIT_VIEWS; fix Views Textfields middle/right-click. #
Messages
Total messages: 5 (0 generated)
|