Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 13895008: Fix the data race of OobeTest.NewUser browser test and enable it. (Closed)

Created:
7 years, 8 months ago by glotov
Modified:
7 years, 8 months ago
CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, arv+watch_chromium.org, Nikita (slow)
Visibility:
Public.

Description

Fix the data race of OobeTest.NewUser browser test and enable it. BUG=178009 TEST=for i in {1..20}; do \ out/Debug/interactive_ui_tests --gtest_filter=OobeTest.NewUser --disable-test-compositor; \ if [ $? != 0 ]; then break; fi; \ done; Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195157

Patch Set 1 #

Patch Set 2 : sync #

Total comments: 3

Patch Set 3 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -15 lines) Patch
M chrome/browser/chromeos/login/oobe_browsertest.cc View 1 2 5 chunks +34 lines, -14 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_gaia_signin.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
glotov
Hi!
7 years, 8 months ago (2013-04-18 16:01:28 UTC) #1
Nikita (slow)
lgtm https://codereview.chromium.org/13895008/diff/19001/chrome/browser/chromeos/login/oobe_browsertest.cc File chrome/browser/chromeos/login/oobe_browsertest.cc (right): https://codereview.chromium.org/13895008/diff/19001/chrome/browser/chromeos/login/oobe_browsertest.cc#newcode211 chrome/browser/chromeos/login/oobe_browsertest.cc:211: // Temporally disabled because of a race: crbug.com/178009 ...
7 years, 8 months ago (2013-04-19 07:34:06 UTC) #2
kjellander_chromium
https://codereview.chromium.org/13895008/diff/19001/chrome/browser/chromeos/login/oobe_browsertest.cc File chrome/browser/chromeos/login/oobe_browsertest.cc (right): https://codereview.chromium.org/13895008/diff/19001/chrome/browser/chromeos/login/oobe_browsertest.cc#newcode211 chrome/browser/chromeos/login/oobe_browsertest.cc:211: // Temporally disabled because of a race: crbug.com/178009 On ...
7 years, 8 months ago (2013-04-19 07:38:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glotov@chromium.org/13895008/29001
7 years, 8 months ago (2013-04-19 09:20:18 UTC) #4
glotov
https://codereview.chromium.org/13895008/diff/19001/chrome/browser/chromeos/login/oobe_browsertest.cc File chrome/browser/chromeos/login/oobe_browsertest.cc (right): https://codereview.chromium.org/13895008/diff/19001/chrome/browser/chromeos/login/oobe_browsertest.cc#newcode211 chrome/browser/chromeos/login/oobe_browsertest.cc:211: // Temporally disabled because of a race: crbug.com/178009 On ...
7 years, 8 months ago (2013-04-19 09:21:12 UTC) #5
commit-bot: I haz the power
7 years, 8 months ago (2013-04-19 13:17:56 UTC) #6
Message was sent while issue was closed.
Change committed as 195157

Powered by Google App Engine
This is Rietveld 408576698