Issue 13892002: Apply the namespace migration for "selectfile.last_directory" user-pref as well.

Issue 13892002: Apply the namespace migration for "selectfile.last_directory" user-pref as well. (Closed)

Created:
7 years, 8 months ago by Haruki Sato

Modified:
7 years, 8 months ago

Reviewers:
achuithb

CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Apply the namespace migration for "selectfile.last_directory" user-pref as well. BUG=229248 TEST=trybots Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193326

Patch Set 2 : add a comment and TODOs. #

Patch Set 3 : fix unittest #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -0 lines)			Patch
M	chrome/browser/chromeos/preferences.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/preferences.cc	View	1	3 chunks	+13 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/preferences_unittest.cc	View	1 2	2 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

achuithb

lgtm https://codereview.chromium.org/13892002/diff/1/chrome/browser/chromeos/preferences.cc File chrome/browser/chromeos/preferences.cc (right): https://codereview.chromium.org/13892002/diff/1/chrome/browser/chromeos/preferences.cc#newcode604 chrome/browser/chromeos/preferences.cc:604: if (drive::util::NeedsNamespaceMigration(pref_path)) { Any chance we could add ...

7 years, 8 months ago (2013-04-09 06:02:35 UTC) #2

Haruki Sato

Thank you for the quick review! https://codereview.chromium.org/13892002/diff/1/chrome/browser/chromeos/preferences.cc File chrome/browser/chromeos/preferences.cc (right): https://codereview.chromium.org/13892002/diff/1/chrome/browser/chromeos/preferences.cc#newcode604 chrome/browser/chromeos/preferences.cc:604: if (drive::util::NeedsNamespaceMigration(pref_path)) { ...

7 years, 8 months ago (2013-04-09 07:43:12 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haruki@chromium.org/13892002/7001

7 years, 8 months ago (2013-04-10 00:56:58 UTC) #4

commit-bot: I haz the power

Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=101477

7 years, 8 months ago (2013-04-10 01:51:06 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haruki@chromium.org/13892002/27001

7 years, 8 months ago (2013-04-10 02:42:12 UTC) #6

Message was sent while issue was closed.

Change committed as 193326

Expand Messages | Collapse Messages