Issue 13891010: [Android] Only write the ordered libraries file when it changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13891010: [Android] Only write the ordered libraries file when it changes (Closed)

Created:
7 years, 8 months ago by cjhopman

Modified:
7 years, 8 months ago

Reviewers:
Yaron

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, klundberg+watch_chromium.org, ilevy+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Android] Only write the ordered libraries file when it changes This action is triggered whenever the top-level library is re-linked. This file being touched then triggers generating a Java file, and then rebuilding/installing the APK. This is all unnecessary. Instead, only write this file if the output has changed. Then, since the ninja generator uses restat=1, dependent actions will only be retriggered when this actual changes (almost never). BUG=158821 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194780

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -2 lines)			Patch
	M	build/android/gyp/util/build_utils.py	View		1 chunk	+11 lines, -0 lines	0 comments	Download
	M	build/android/gyp/write_ordered_libraries.py	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/13891010/1

7 years, 8 months ago (2013-04-18 00:50:43 UTC) #3

Message was sent while issue was closed.

Change committed as 194780

Expand Messages | Collapse Messages