Make sure plugin element is focused in PluginDocument.

Make sure plugin element is focused in PluginDocument.

Plugins that are embedded via PluginDocument currently have no way to
focus themselves, and this forces users to provide the focus manually
(e.g. a password-protected PDF requires the user to click in the tab
before they can start typing). It seems reasonable that the <embed>
element in the PluginDocument page should be focused when it is
created.

BUG=536637
Committed: https://crrev.com/1fa6773918c92371dcaf91edbdb3285f6d50026d
Cr-Commit-Position: refs/heads/master@{#352991}

[wjmaclean, 2015-10-06 21:13:53]

wjmaclean@chromium.org changed reviewers:
+ esprehn@chromium.org

[wjmaclean, 2015-10-07 12:40:04]

esprehn@ - could you please take a look?

[esprehn, 2015-10-07 21:24:08]

Hmm, can I create a PluginDocument with <iframe src=thing.swf> ? Any iframe can
request focus today, so it's not a security thing I just wonder if existing
content will break. I guess embedding that way is probably super rare.

Lgtm, thanks for writing a test too. You're awesome. :)

[wjmaclean, 2015-10-07 23:28:25]

On 2015/10/07 21:24:08, esprehn wrote:
> Hmm, can I create a PluginDocument with <iframe src=thing.swf> ? Any iframe
can
> request focus today, so it's not a security thing I just wonder if existing
> content will break. I guess embedding that way is probably super rare.
> 
> Lgtm, thanks for writing a test too. You're awesome. :)

We'll roll the dice ... at least there's a workaround for the case you suggest,
if people actually do it.

[wjmaclean, 2015-10-07 23:28:33]

The CQ bit was checked by wjmaclean@chromium.org

[commit-bot: I haz the power, 2015-10-07 23:29:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1389093002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1389093002/1

[commit-bot: I haz the power, 2015-10-08 00:51:59]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-10-08 00:52:57]

Patchset 1 (id:??) landed as
https://crrev.com/1fa6773918c92371dcaf91edbdb3285f6d50026d
Cr-Commit-Position: refs/heads/master@{#352991}