Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2054)

Unified Diff: content/renderer/gpu/compositor_output_surface.cc

Issue 138903025: Read compositor VSync information from platform, when possible (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: 4b969456 piman@ comments; refactor logic into CompositorVSyncManager Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/gpu/compositor_output_surface.cc
diff --git a/content/renderer/gpu/compositor_output_surface.cc b/content/renderer/gpu/compositor_output_surface.cc
index 7cb51996d4fc94e9ac117a4d0302bc010836f7ff..cdcc1c8f16b7bf357427de07b56e4960d91d2681 100644
--- a/content/renderer/gpu/compositor_output_surface.cc
+++ b/content/renderer/gpu/compositor_output_surface.cc
@@ -138,7 +138,8 @@ void CompositorOutputSurface::OnMessageReceived(const IPC::Message& message) {
if (!HasClient())
return;
IPC_BEGIN_MESSAGE_MAP(CompositorOutputSurface, message)
- IPC_MESSAGE_HANDLER(ViewMsg_UpdateVSyncParameters, OnUpdateVSyncParameters);
+ IPC_MESSAGE_HANDLER(ViewMsg_UpdateVSyncParameters,
+ OnUpdateVSyncParametersFromView);
piman 2014/02/04 04:51:01 nit: gratuitous rename? Not sure which "FromView"
sheu 2014/02/04 22:01:45 A little bit convoluted. See comment in BrowserCo
piman 2014/02/04 22:52:54 Note: BrowserCompositorOutputSurface doesn't deriv
IPC_MESSAGE_HANDLER(ViewMsg_SwapCompositorFrameAck, OnSwapAck);
IPC_MESSAGE_HANDLER(ViewMsg_ReclaimCompositorResources, OnReclaimResources);
#if defined(OS_ANDROID)
@@ -147,10 +148,10 @@ void CompositorOutputSurface::OnMessageReceived(const IPC::Message& message) {
IPC_END_MESSAGE_MAP()
}
-void CompositorOutputSurface::OnUpdateVSyncParameters(
+void CompositorOutputSurface::OnUpdateVSyncParametersFromView(
base::TimeTicks timebase, base::TimeDelta interval) {
DCHECK(CalledOnValidThread());
- OnVSyncParametersChanged(timebase, interval);
+ CommitVSyncParameters(timebase, interval);
}
#if defined(OS_ANDROID)

Powered by Google App Engine
This is Rietveld 408576698