Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 13888007: Rewrite scoped_array<T> to scoped_ptr<T[]> in sandbox. (Closed)

Created:
7 years, 8 months ago by dcheng
Modified:
7 years, 8 months ago
CC:
chromium-reviews, cpu_(ooo_6.6-7.5), rvargas (doing something else)
Visibility:
Public.

Description

Rewrite scoped_array<T> to scoped_ptr<T[]> in sandbox. This is a manual cleanup pass using sed for files which are not built on Linux. BUG=171111 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194027

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M sandbox/win/src/handle_closer.cc View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/win/src/interception.cc View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/win/src/interception_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M sandbox/win/src/service_resolver_32.cc View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/win/src/service_resolver_64.cc View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/win/src/service_resolver_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/win/src/win_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/win/src/window.cc View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/win/wow_helper/service64_resolver.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
dcheng
7 years, 8 months ago (2013-04-10 23:31:39 UTC) #1
dcheng
Ping?
7 years, 8 months ago (2013-04-12 17:00:47 UTC) #2
nsylvain
(dcheng pinged me) LGTM
7 years, 8 months ago (2013-04-12 19:04:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/13888007/1
7 years, 8 months ago (2013-04-12 19:06:35 UTC) #4
commit-bot: I haz the power
Presubmit check for 13888007-1 failed and returned exit status 1. INFO:root:Found 9 file(s). Running presubmit ...
7 years, 8 months ago (2013-04-12 19:06:58 UTC) #5
Nicolas Sylvain
lgtm
7 years, 8 months ago (2013-04-12 19:09:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/13888007/1
7 years, 8 months ago (2013-04-12 19:12:29 UTC) #7
jschuh
lgtm
7 years, 8 months ago (2013-04-12 19:31:06 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) interactive_ui_tests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=116811
7 years, 8 months ago (2013-04-12 19:48:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/13888007/1
7 years, 8 months ago (2013-04-12 19:48:59 UTC) #10
commit-bot: I haz the power
7 years, 8 months ago (2013-04-12 22:26:08 UTC) #11
Message was sent while issue was closed.
Change committed as 194027

Powered by Google App Engine
This is Rietveld 408576698