Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 138843011: Cast: Adding helper crypto classes (Closed)

Created:
6 years, 10 months ago by mikhal1
Modified:
6 years, 10 months ago
Reviewers:
hubbe
CC:
chromium-reviews, hclam+watch_chromium.org, mikhal+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, pwestin+watch_google.com, feature-media-reviews_chromium.org, hubbe+watch_chromium.org, miu+watch_chromium.org
Visibility:
Public.

Description

Cast: Adding helper crypto classes Adding two helper classes to handle encryption and decryption. This reduces code duplication between audio and video. In addition, cleaned up the .gyp files from obselete includes of crypto.gyp Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248522

Patch Set 1 #

Total comments: 10

Patch Set 2 : Responding to review #

Total comments: 1

Patch Set 3 : nit #

Patch Set 4 : Fix compile issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+217 lines, -193 lines) Patch
M media/cast/audio_receiver/audio_receiver.h View 1 2 chunks +2 lines, -8 lines 0 comments Download
M media/cast/audio_receiver/audio_receiver.cc View 1 2 6 chunks +19 lines, -38 lines 0 comments Download
M media/cast/audio_receiver/audio_receiver.gypi View 1 1 chunk +2 lines, -2 lines 0 comments Download
M media/cast/audio_sender/audio_sender.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M media/cast/cast.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M media/cast/cast_defines.h View 2 chunks +0 lines, -19 lines 0 comments Download
M media/cast/cast_receiver.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M media/cast/cast_sender.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M media/cast/transport/cast_transport.gyp View 1 2 chunks +6 lines, -6 lines 0 comments Download
M media/cast/transport/cast_transport_defines.h View 2 chunks +21 lines, -0 lines 0 comments Download
M media/cast/transport/transport_audio_sender.h View 1 2 chunks +3 lines, -8 lines 0 comments Download
M media/cast/transport/transport_audio_sender.cc View 3 chunks +6 lines, -27 lines 0 comments Download
M media/cast/transport/transport_video_sender.h View 1 2 chunks +2 lines, -10 lines 0 comments Download
M media/cast/transport/transport_video_sender.cc View 1 4 chunks +6 lines, -28 lines 0 comments Download
A media/cast/transport/utility/transport_encryption_handler.h View 1 1 chunk +53 lines, -0 lines 0 comments Download
A media/cast/transport/utility/transport_encryption_handler.cc View 1 1 chunk +76 lines, -0 lines 0 comments Download
A + media/cast/transport/utility/utility.gypi View 1 1 chunk +9 lines, -8 lines 0 comments Download
M media/cast/video_receiver/video_receiver.h View 1 2 chunks +2 lines, -8 lines 0 comments Download
M media/cast/video_receiver/video_receiver.cc View 1 2 3 6 chunks +9 lines, -25 lines 0 comments Download
M media/cast/video_receiver/video_receiver.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M media/cast/video_sender/video_sender.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 27 (0 generated)
mikhal1
Please review, -Mikhal
6 years, 10 months ago (2014-01-31 16:37:23 UTC) #1
hubbe
https://chromiumcodereview.appspot.com/138843011/diff/1/media/cast/audio_receiver/audio_receiver.cc File media/cast/audio_receiver/audio_receiver.cc (right): https://chromiumcodereview.appspot.com/138843011/diff/1/media/cast/audio_receiver/audio_receiver.cc#newcode88 media/cast/audio_receiver/audio_receiver.cc:88: decryptor_(), There is no need to call the default ...
6 years, 10 months ago (2014-01-31 17:46:21 UTC) #2
mikhal1
PTAL https://chromiumcodereview.appspot.com/138843011/diff/1/media/cast/audio_receiver/audio_receiver.cc File media/cast/audio_receiver/audio_receiver.cc (right): https://chromiumcodereview.appspot.com/138843011/diff/1/media/cast/audio_receiver/audio_receiver.cc#newcode88 media/cast/audio_receiver/audio_receiver.cc:88: decryptor_(), On 2014/01/31 17:46:22, hubbe wrote: > There ...
6 years, 10 months ago (2014-01-31 18:22:46 UTC) #3
hubbe
LGTM with one thing to fix... https://chromiumcodereview.appspot.com/138843011/diff/60002/media/cast/audio_receiver/audio_receiver.cc File media/cast/audio_receiver/audio_receiver.cc (right): https://chromiumcodereview.appspot.com/138843011/diff/60002/media/cast/audio_receiver/audio_receiver.cc#newcode167 media/cast/audio_receiver/audio_receiver.cc:167: plaintext = std::string(reinterpret_cast<const ...
6 years, 10 months ago (2014-01-31 18:30:38 UTC) #4
mikhal1
The CQ bit was checked by mikhal@chromium.org
6 years, 10 months ago (2014-01-31 18:38:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mikhal@chromium.org/138843011/370001
6 years, 10 months ago (2014-01-31 18:39:46 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-01-31 18:59:30 UTC) #7
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=219225
6 years, 10 months ago (2014-01-31 18:59:30 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 18:59:34 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 18:59:38 UTC) #10
mikhal1
The CQ bit was checked by mikhal@chromium.org
6 years, 10 months ago (2014-01-31 22:36:34 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mikhal@chromium.org/138843011/600001
6 years, 10 months ago (2014-01-31 22:37:53 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-01-31 23:04:48 UTC) #13
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=221707
6 years, 10 months ago (2014-01-31 23:04:49 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 23:04:52 UTC) #15
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 23:04:52 UTC) #16
mikhal1
The CQ bit was checked by mikhal@chromium.org
6 years, 10 months ago (2014-02-03 15:49:04 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mikhal@chromium.org/138843011/600001
6 years, 10 months ago (2014-02-03 15:49:24 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-03 16:15:10 UTC) #19
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) net_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=222249
6 years, 10 months ago (2014-02-03 16:15:12 UTC) #20
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 16:15:15 UTC) #21
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 16:15:19 UTC) #22
mikhal1
The CQ bit was checked by mikhal@chromium.org
6 years, 10 months ago (2014-02-03 16:57:02 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mikhal@chromium.org/138843011/600001
6 years, 10 months ago (2014-02-03 16:57:22 UTC) #24
commit-bot: I haz the power
Change committed as 248522
6 years, 10 months ago (2014-02-03 17:55:27 UTC) #25
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 17:55:29 UTC) #26
commit-bot: I haz the power
6 years, 10 months ago (2014-02-03 17:55:32 UTC) #27
Message was sent while issue was closed. 
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698