Issue 13884014: Ensures that local git config is used while checking if it is a Git-svn repo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13884014: Ensures that local git config is used while checking if it is a Git-svn repo. (Closed)

Created:
7 years, 8 months ago by zimmerle

Modified:
7 years, 8 months ago

Reviewers:
Dirk Pranke, M-A Ruel

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Visibility:
Public.

More Reviews

Description

Ensures that local git config is used while checking if it is a Git-svn repo. If no `--local` option is passed to git config command line tool, it will relies on the local repository and then to the user configuration ($HOME/.gitconfig). In case the user has - for some reason - a svn repository configured in this user configuration, the checking: `git config --get-regexp ^svn-remote\.` will accuse that there is svn repo and so the `git cl tool`. This patch just add the option `--local` to the git config command line tool, avoiding this situation. R=maruel@chromium.org,dpranke@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=193987

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	git_cl.py	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	tests/git_cl_test.py	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zimmerle@gmail.com/13884014/1

7 years, 8 months ago (2013-04-12 19:37:22 UTC) #2

Message was sent while issue was closed.

Change committed as 193987

Expand Messages | Collapse Messages