Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 1388323003: Add "sub immediate" instruction to the ARM integrated assembler. (Closed)

Created:
5 years, 2 months ago by Karl
Modified:
5 years, 2 months ago
Reviewers:
Jim Stichnoth, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove tabs. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -11 lines) Patch
M src/IceAssemblerARM32.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/IceAssemblerARM32.cpp View 2 chunks +31 lines, -0 lines 0 comments Download
M src/IceInstARM32.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M tests_lit/assembler/arm32/add.ll View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + tests_lit/assembler/arm32/sub.ll View 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Karl
5 years, 2 months ago (2015-10-14 16:57:01 UTC) #2
Jim Stichnoth
otherwise lgtm https://chromiumcodereview.appspot.com/1388323003/diff/1/tests_lit/assembler/arm32/sub.ll File tests_lit/assembler/arm32/sub.ll (right): https://chromiumcodereview.appspot.com/1388323003/diff/1/tests_lit/assembler/arm32/sub.ll#newcode17 tests_lit/assembler/arm32/sub.ll:17: ; ASM: sub r0, r0, #1 remove ...
5 years, 2 months ago (2015-10-14 17:00:35 UTC) #3
Karl
Committed patchset #2 (id:20001) manually as e34550538720950cf114f9a4e6e43ef25c7401e5 (presubmit successful).
5 years, 2 months ago (2015-10-14 21:30:25 UTC) #4
Karl
5 years, 2 months ago (2015-10-14 21:30:39 UTC) #5
Message was sent while issue was closed.
https://chromiumcodereview.appspot.com/1388323003/diff/1/tests_lit/assembler/...
File tests_lit/assembler/arm32/sub.ll (right):

https://chromiumcodereview.appspot.com/1388323003/diff/1/tests_lit/assembler/...
tests_lit/assembler/arm32/sub.ll:17: ; ASM:	sub	r0, r0, #1
On 2015/10/14 17:00:35, stichnot wrote:
> remove tab characters (probably from the add test as well)

Done.

Powered by Google App Engine
This is Rietveld 408576698