Draft of new codelab for review

changes based on run-through and update of screenshots


re-drafted codelab


first rough draft of deploy code lab

BUG=
R=sethladd@google.com

Committed: 28edfdd

[mem, 2014-01-14 20:52:39]

Howdy Peeps:
Please review the new codelab. I would appreciate your thoughts, comments,
corrections, and whatnot.

Thanks.
mem

Hosted here:

https://first-looksies-newcodelab-dot-dart-lang.appspot.com/codelabs/deploy/

[sethladd, 2014-01-14 22:44:05]

https://chromiumcodereview.appspot.com/138823002/diff/1/src/site/codelabs/dar...
File src/site/codelabs/darrrt/index.markdown (right):

https://chromiumcodereview.appspot.com/138823002/diff/1/src/site/codelabs/dar...
src/site/codelabs/darrrt/index.markdown:4: description: "Write some Dart code.
Learn some stuff."
can we convey this is a great place to starting learning dart? how do we convey
this can be Step One?

https://chromiumcodereview.appspot.com/138823002/diff/1/src/site/codelabs/dar...
src/site/codelabs/darrrt/index.markdown:67: <div style="padding-left: 10px">
does this happen only in the code lab?

https://chromiumcodereview.appspot.com/138823002/diff/1/src/site/codelabs/dep...
File src/site/codelabs/deploy/index.markdown (right):

https://chromiumcodereview.appspot.com/138823002/diff/1/src/site/codelabs/dep...
src/site/codelabs/deploy/index.markdown:4: description: "Get it out there."
what's better than "it" ? think SEO :)

https://chromiumcodereview.appspot.com/138823002/diff/1/src/site/codelabs/dep...
src/site/codelabs/deploy/index.markdown:19: # {{ page.title }}
global: can we add a diagram showing the pieces? the app, the build dir, the
HTTP server, running "in the cloud" ?

https://chromiumcodereview.appspot.com/138823002/diff/1/src/site/codelabs/dep...
src/site/codelabs/deploy/index.markdown:19: # {{ page.title }}
suggestion: show how to use dev tools to open the local app on your phone

https://chromiumcodereview.appspot.com/138823002/diff/1/src/site/codelabs/dep...
src/site/codelabs/deploy/index.markdown:22: you learn to build an existing app
you also learn how to build a basic http server

https://chromiumcodereview.appspot.com/138823002/diff/1/src/site/codelabs/dep...
src/site/codelabs/deploy/index.markdown:25: Heroku is just one of many options
I wonder if we should define what heroku is.

https://chromiumcodereview.appspot.com/138823002/diff/1/src/site/codelabs/dep...
src/site/codelabs/deploy/index.markdown:31: a Dart web app before.
link to step 1?

https://chromiumcodereview.appspot.com/138823002/diff/1/src/site/codelabs/dep...
src/site/codelabs/deploy/index.markdown:294: * `any` means any version of the
package will do.
clarify that it also means the latest package that matches your SDK?

https://chromiumcodereview.appspot.com/138823002/diff/1/src/site/codelabs/dep...
src/site/codelabs/deploy/index.markdown:321: * The `http-server` package
implements high-level HTTP server
underscore. http_server

https://chromiumcodereview.appspot.com/138823002/diff/1/src/site/codelabs/dep...
src/site/codelabs/deploy/index.markdown:398: open
`deploy-codelab-master/build/piratebadge.html` using **File > Open File...**.
Do you mean to use the OS's file browser ? or the browser's File > Open

https://chromiumcodereview.appspot.com/138823002/diff/1/src/site/codelabs/dep...
src/site/codelabs/deploy/index.markdown:418: originates from the Heroku
buildpack written by Ilya Grigorik.
too much info?

https://chromiumcodereview.appspot.com/138823002/diff/1/src/site/codelabs/dep...
src/site/codelabs/deploy/index.markdown:630: * The server binds to a host
`0.0.0.0`, which designates an unknown target.
0.0.0.0 is INADDR_ANY, which is is a special address that is guaranteed to
receive from any network socket. If you don't know what specific IP to listen
to, you can use 0.0.0.0

https://chromiumcodereview.appspot.com/138823002/diff/1/src/site/codelabs/dep...
src/site/codelabs/deploy/index.markdown:739: so that the port number can be
passed to your app.
I think user-env-compile only is used to pass env variables to the build script
during deploy. It's not used for $PORT

https://chromiumcodereview.appspot.com/138823002/diff/1/src/site/codelabs/dep...
src/site/codelabs/deploy/index.markdown:742: This special build is at the URL
specified by `DART_SDK_URL`.
Define what "special" means. Also, disclaimer that we are pointing to an
unsupported build.

https://chromiumcodereview.appspot.com/138823002/diff/1/src/site/codelabs/dep...
src/site/codelabs/deploy/index.markdown:871: <img src="images/mobile_better.png"
height="400">
this is an iOS screenshot in an android phone.

https://chromiumcodereview.appspot.com/138823002/diff/1/src/site/codelabs/dep...
src/site/codelabs/deploy/index.markdown:960: data-text="Arrr! I've deployed me
app. http://dartlang.org/codelab/deploy/"
I don't know if this is working. I clicked it but the text didn't show up

[mem, 2014-01-15 23:22:50]

put in seth's comments (all but one...didn't put in a section about dev tools
just yet).

Is the top diagram horrifying?

https://first-looksies-newcodelab-dot-dart-lang.appspot.com/codelabs/deploy/

mem

https://chromiumcodereview.appspot.com/138823002/diff/1/src/site/codelabs/dar...
File src/site/codelabs/darrrt/index.markdown (right):

https://chromiumcodereview.appspot.com/138823002/diff/1/src/site/codelabs/dar...
src/site/codelabs/darrrt/index.markdown:4: description: "Write some Dart code.
Learn some stuff."
On 2014/01/14 22:44:06, sethladd wrote:
> can we convey this is a great place to starting learning dart? how do we
convey
> this can be Step One?

Done.

https://chromiumcodereview.appspot.com/138823002/diff/1/src/site/codelabs/dar...
src/site/codelabs/darrrt/index.markdown:67: <div style="padding-left: 10px">
It's about centering...

If the button is centered, the arrow is at the left of the button as it should
be. In the tutorial the button is aligned to the left of the page, so the
arrow's position is off.

I tried tracking it down, but it was a rabbit hole and I didn't want to get
distracted.



On 2014/01/14 22:44:06, sethladd wrote:
> does this happen only in the code lab?

https://chromiumcodereview.appspot.com/138823002/diff/1/src/site/codelabs/dep...
File src/site/codelabs/deploy/index.markdown (right):

https://chromiumcodereview.appspot.com/138823002/diff/1/src/site/codelabs/dep...
src/site/codelabs/deploy/index.markdown:4: description: "Get it out there."
On 2014/01/14 22:44:06, sethladd wrote:
> what's better than "it" ? think SEO :)

Done.

https://chromiumcodereview.appspot.com/138823002/diff/1/src/site/codelabs/dep...
src/site/codelabs/deploy/index.markdown:19: # {{ page.title }}
On 2014/01/14 22:44:06, sethladd wrote:
> global: can we add a diagram showing the pieces? the app, the build dir, the
> HTTP server, running "in the cloud" ?

Done.

https://chromiumcodereview.appspot.com/138823002/diff/1/src/site/codelabs/dep...
src/site/codelabs/deploy/index.markdown:22: you learn to build an existing app
On 2014/01/14 22:44:06, sethladd wrote:
> you also learn how to build a basic http server

Done.

https://chromiumcodereview.appspot.com/138823002/diff/1/src/site/codelabs/dep...
src/site/codelabs/deploy/index.markdown:25: Heroku is just one of many options
On 2014/01/14 22:44:06, sethladd wrote:
> I wonder if we should define what heroku is.

Done.

https://chromiumcodereview.appspot.com/138823002/diff/1/src/site/codelabs/dep...
src/site/codelabs/deploy/index.markdown:31: a Dart web app before.
On 2014/01/14 22:44:06, sethladd wrote:
> link to step 1?

Done.

https://chromiumcodereview.appspot.com/138823002/diff/1/src/site/codelabs/dep...
src/site/codelabs/deploy/index.markdown:294: * `any` means any version of the
package will do.
On 2014/01/14 22:44:06, sethladd wrote:
> clarify that it also means the latest package that matches your SDK?

Done.

https://chromiumcodereview.appspot.com/138823002/diff/1/src/site/codelabs/dep...
src/site/codelabs/deploy/index.markdown:294: * `any` means any version of the
package will do.
On 2014/01/14 22:44:06, sethladd wrote:
> clarify that it also means the latest package that matches your SDK?

Done.

https://chromiumcodereview.appspot.com/138823002/diff/1/src/site/codelabs/dep...
src/site/codelabs/deploy/index.markdown:321: * The `http-server` package
implements high-level HTTP server
On 2014/01/14 22:44:06, sethladd wrote:
> underscore. http_server

Done.

https://chromiumcodereview.appspot.com/138823002/diff/1/src/site/codelabs/dep...
src/site/codelabs/deploy/index.markdown:398: open
`deploy-codelab-master/build/piratebadge.html` using **File > Open File...**.
On 2014/01/14 22:44:06, sethladd wrote:
> Do you mean to use the OS's file browser ? or the browser's File > Open

Done.

https://chromiumcodereview.appspot.com/138823002/diff/1/src/site/codelabs/dep...
src/site/codelabs/deploy/index.markdown:418: originates from the Heroku
buildpack written by Ilya Grigorik.
On 2014/01/14 22:44:06, sethladd wrote:
> too much info?

Done.

https://chromiumcodereview.appspot.com/138823002/diff/1/src/site/codelabs/dep...
src/site/codelabs/deploy/index.markdown:630: * The server binds to a host
`0.0.0.0`, which designates an unknown target.
On 2014/01/14 22:44:06, sethladd wrote:
> 0.0.0.0 is INADDR_ANY, which is is a special address that is guaranteed to
> receive from any network socket. If you don't know what specific IP to listen
> to, you can use 0.0.0.0

Done.

https://chromiumcodereview.appspot.com/138823002/diff/1/src/site/codelabs/dep...
src/site/codelabs/deploy/index.markdown:739: so that the port number can be
passed to your app.
On 2014/01/14 22:44:06, sethladd wrote:
> I think user-env-compile only is used to pass env variables to the build
script
> during deploy. It's not used for $PORT

Done.

https://chromiumcodereview.appspot.com/138823002/diff/1/src/site/codelabs/dep...
src/site/codelabs/deploy/index.markdown:742: This special build is at the URL
specified by `DART_SDK_URL`.
On 2014/01/14 22:44:06, sethladd wrote:
> Define what "special" means. Also, disclaimer that we are pointing to an
> unsupported build.

Done.

https://chromiumcodereview.appspot.com/138823002/diff/1/src/site/codelabs/dep...
src/site/codelabs/deploy/index.markdown:871: <img src="images/mobile_better.png"
height="400">
On 2014/01/14 22:44:06, sethladd wrote:
> this is an iOS screenshot in an android phone.

Done.

https://chromiumcodereview.appspot.com/138823002/diff/1/src/site/codelabs/dep...
src/site/codelabs/deploy/index.markdown:960: data-text="Arrr! I've deployed me
app. http://dartlang.org/codelab/deploy/"
On 2014/01/14 22:44:06, sethladd wrote:
> I don't know if this is working. I clicked it but the text didn't show up

Done.

[Kathy Walrath, 2014-01-16 00:01:29]

Some feedback from a quick look through. I still haven't followed the
instructions but would like to...

https://chromiumcodereview.appspot.com/138823002/diff/340001/src/site/codelab...
File src/site/codelabs/deploy/index.markdown (right):

https://chromiumcodereview.appspot.com/138823002/diff/340001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:60: * [Step 3: Code walkthrough of a
static server](#step-three)
It's weird to have a non-action-oriented name. Maybe:

Build a static server for Heroku

https://chromiumcodereview.appspot.com/138823002/diff/340001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:166: ### <i class="fa fa-anchor"> </i>
Two notes about `piratebadge.html`
Um... What are the two notes?

Even if you're referring to the (three) list items to the side, I'd rename this
section. Maybe "Look at piratebadge.html."

(Note, the title should end with a period.)

https://chromiumcodereview.appspot.com/138823002/diff/340001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:172: Double click on `piratebadge.html`
to open it.
Double click on -> Double-click

(no "on", and use a hyphen)

https://chromiumcodereview.appspot.com/138823002/diff/340001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:216: Click on `piratebadge.html`
Click on -> Select

https://chromiumcodereview.appspot.com/138823002/diff/340001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:238: You should see a text field and a
button on the left,
Describing the image seems weird, plus "as below"... sounds weird. Maybe:

The Pirate Badge app should appear, looking like this:

https://chromiumcodereview.appspot.com/138823002/diff/340001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:277: Double click the `pubspec.yaml`
file to open it.
Double click -> Double-click

https://chromiumcodereview.appspot.com/138823002/diff/340001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:337: *  The `mime` package is included
because `http_server` has a dependency on it.
has a dependency --> depends

https://chromiumcodereview.appspot.com/138823002/diff/340001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:347: Bring up a terminal window,
I was surprised this was in a terminal window, instead of Dart Editor. Is there
a reason to do it this way?

(I guess I expected to stay in Dart Editor as long as possible, maybe with a
note to the right that you could instead run `pub build` in a terminal window.)

https://chromiumcodereview.appspot.com/138823002/diff/340001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:390: * The `piratebadge.dart.js` file is
JavaScript file that has been minimized.
is -> is a

https://chromiumcodereview.appspot.com/138823002/diff/340001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:428: 
I'd like some wording here about how you don't need to do this step if you're
deploying to Heroku.

But since they've come this far, why not learn how to run Dart code on a server?

https://chromiumcodereview.appspot.com/138823002/diff/340001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:638: * Creates an `HttpServer` object
which responds to HTTP requests
Subject is missing here

https://chromiumcodereview.appspot.com/138823002/diff/340001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:854: and on a mobile device.
This seems to imply that you can't run the app on mobile until you've deployed
to the internet.

Could we run on mobile sooner?

If that's inconvenient, how about just saying "Run the app on the internet" and
include mobile as just one of the ways to run your app.

https://chromiumcodereview.appspot.com/138823002/diff/340001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:960: Now that your app is deployed for
the world to use.
sentence fragment

https://chromiumcodereview.appspot.com/138823002/diff/340001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:988: ### <i class="fa fa-anchor"> </i>
Jump to another ship.
funny!

https://chromiumcodereview.appspot.com/138823002/diff/340001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:992: * Write the pirate web app in [Code
Lab: Ready the Pirates](/codelabs/darrrt/).
This seems weird, since it was kind of a prerequisite. (Also, the title
changed.) Maybe:

If you never went through the [Pirate Convention] code lab, do it now.

https://chromiumcodereview.appspot.com/138823002/diff/340001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:993: * Visit [Dart by
Example](/dart-by-example/) for a rich set of targeted Dart examples.
smacks of buzzwords: rich! targeted!

Be more specific.

[mem, 2014-01-16 22:48:59]

PTAL

Added new section on using DevTools. I need to do a read-through myself, but
thought I'd put this out there again to hurry it along. And yes, I know about
the compouter typo.

https://first-looksies-newcodelab-dot-dart-lang.appspot.com/codelabs/deploy/
mem

https://chromiumcodereview.appspot.com/138823002/diff/1/src/site/codelabs/dep...
File src/site/codelabs/deploy/index.markdown (right):

https://chromiumcodereview.appspot.com/138823002/diff/1/src/site/codelabs/dep...
src/site/codelabs/deploy/index.markdown:19: # {{ page.title }}
On 2014/01/14 22:44:06, sethladd wrote:
> global: can we add a diagram showing the pieces? the app, the build dir, the
> HTTP server, running "in the cloud" ?

Done.

https://chromiumcodereview.appspot.com/138823002/diff/1/src/site/codelabs/dep...
src/site/codelabs/deploy/index.markdown:19: # {{ page.title }}
On 2014/01/14 22:44:06, sethladd wrote:
> suggestion: show how to use dev tools to open the local app on your phone

Done.

https://chromiumcodereview.appspot.com/138823002/diff/340001/src/site/codelab...
File src/site/codelabs/deploy/index.markdown (right):

https://chromiumcodereview.appspot.com/138823002/diff/340001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:60: * [Step 3: Code walkthrough of a
static server](#step-three)
On 2014/01/16 00:01:29, Kathy Walrath wrote:
> It's weird to have a non-action-oriented name. Maybe:
> 
> Build a static server for Heroku

Done.

https://chromiumcodereview.appspot.com/138823002/diff/340001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:166: ### <i class="fa fa-anchor"> </i>
Two notes about `piratebadge.html`
On 2014/01/16 00:01:29, Kathy Walrath wrote:
> Um... What are the two notes?
> 
> Even if you're referring to the (three) list items to the side, I'd rename
this
> section. Maybe "Look at piratebadge.html."
> 
> (Note, the title should end with a period.)

Done.

https://chromiumcodereview.appspot.com/138823002/diff/340001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:166: ### <i class="fa fa-anchor"> </i>
Two notes about `piratebadge.html`
On 2014/01/16 00:01:29, Kathy Walrath wrote:
> Um... What are the two notes?
> 
> Even if you're referring to the (three) list items to the side, I'd rename
this
> section. Maybe "Look at piratebadge.html."
> 
> (Note, the title should end with a period.)

Done.

https://chromiumcodereview.appspot.com/138823002/diff/340001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:172: Double click on `piratebadge.html`
to open it.
On 2014/01/16 00:01:29, Kathy Walrath wrote:
> Double click on -> Double-click
> 
> (no "on", and use a hyphen)

Done.

https://chromiumcodereview.appspot.com/138823002/diff/340001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:216: Click on `piratebadge.html`
On 2014/01/16 00:01:29, Kathy Walrath wrote:
> Click on -> Select

Done.

https://chromiumcodereview.appspot.com/138823002/diff/340001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:216: Click on `piratebadge.html`
On 2014/01/16 00:01:29, Kathy Walrath wrote:
> Click on -> Select

Done.

https://chromiumcodereview.appspot.com/138823002/diff/340001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:238: You should see a text field and a
button on the left,
On 2014/01/16 00:01:29, Kathy Walrath wrote:
> Describing the image seems weird, plus "as below"... sounds weird. Maybe:
> 
> The Pirate Badge app should appear, looking like this:

Done.

https://chromiumcodereview.appspot.com/138823002/diff/340001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:277: Double click the `pubspec.yaml`
file to open it.
On 2014/01/16 00:01:29, Kathy Walrath wrote:
> Double click -> Double-click

Done.

https://chromiumcodereview.appspot.com/138823002/diff/340001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:337: *  The `mime` package is included
because `http_server` has a dependency on it.
On 2014/01/16 00:01:29, Kathy Walrath wrote:
> has a dependency --> depends

Done.

https://chromiumcodereview.appspot.com/138823002/diff/340001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:347: Bring up a terminal window,
On 2014/01/16 00:01:29, Kathy Walrath wrote:
> I was surprised this was in a terminal window, instead of Dart Editor. Is
there
> a reason to do it this way?
> 
> (I guess I expected to stay in Dart Editor as long as possible, maybe with a
> note to the right that you could instead run `pub build` in a terminal
window.)

it wasn't working in Dart Editor.

now it does.

https://chromiumcodereview.appspot.com/138823002/diff/340001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:390: * The `piratebadge.dart.js` file is
JavaScript file that has been minimized.
On 2014/01/16 00:01:29, Kathy Walrath wrote:
> is -> is a

Done.

https://chromiumcodereview.appspot.com/138823002/diff/340001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:428: 
On 2014/01/16 00:01:29, Kathy Walrath wrote:
> I'd like some wording here about how you don't need to do this step if you're
> deploying to Heroku.
> 
> But since they've come this far, why not learn how to run Dart code on a
server?

Done.

https://chromiumcodereview.appspot.com/138823002/diff/340001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:638: * Creates an `HttpServer` object
which responds to HTTP requests
On 2014/01/16 00:01:29, Kathy Walrath wrote:
> Subject is missing here

Done.

https://chromiumcodereview.appspot.com/138823002/diff/340001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:854: and on a mobile device.
I edited to make a new section.

mem

On 2014/01/16 00:01:29, Kathy Walrath wrote:
> This seems to imply that you can't run the app on mobile until you've deployed
> to the internet.
> 
> Could we run on mobile sooner?
> 
> If that's inconvenient, how about just saying "Run the app on the internet"
and
> include mobile as just one of the ways to run your app.

https://chromiumcodereview.appspot.com/138823002/diff/340001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:960: Now that your app is deployed for
the world to use.
On 2014/01/16 00:01:29, Kathy Walrath wrote:
> sentence fragment

Done.

https://chromiumcodereview.appspot.com/138823002/diff/340001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:988: ### <i class="fa fa-anchor"> </i>
Jump to another ship.
On 2014/01/16 00:01:29, Kathy Walrath wrote:
> funny!

thx :-)

https://chromiumcodereview.appspot.com/138823002/diff/340001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:992: * Write the pirate web app in [Code
Lab: Ready the Pirates](/codelabs/darrrt/).
On 2014/01/16 00:01:29, Kathy Walrath wrote:
> This seems weird, since it was kind of a prerequisite. (Also, the title
> changed.) Maybe:
> 
> If you never went through the [Pirate Convention] code lab, do it now. 

Done.

https://chromiumcodereview.appspot.com/138823002/diff/340001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:993: * Visit [Dart by
Example](/dart-by-example/) for a rich set of targeted Dart examples.
On 2014/01/16 00:01:29, Kathy Walrath wrote:
> smacks of buzzwords: rich! targeted!
> 
> Be more specific.

Done.

[sethladd, 2014-01-17 00:07:23]

Some thoughts.

https://chromiumcodereview.appspot.com/138823002/diff/660001/src/site/codelab...
File src/site/codelabs/deploy/index.markdown (right):

https://chromiumcodereview.appspot.com/138823002/diff/660001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:23: you need to put it on the internet
so that people can use it.
s/internet/web

https://chromiumcodereview.appspot.com/138823002/diff/660001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:26: you learn to deploy an app to the
internet using the
how about, "You will learn how to build a Dart app for deployment to web. You
will then learn how to serve that app so browsers can access it. Finally, you
will learn one way to deploy the app to the web."

In other words, can you descrive what they will learn as shown in your diagram?

https://chromiumcodereview.appspot.com/138823002/diff/660001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:34: In this code lab, you deploy the
Pirate Badge app from the
In this code lab leads two paragraphs

https://chromiumcodereview.appspot.com/138823002/diff/660001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:145: ##Step 1: Run the app in Dart
Editor {#step-one}
Is it running in Dart Editor or Dartium?

https://chromiumcodereview.appspot.com/138823002/diff/660001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:422: Heroku requires that you provide a
static file server with your project.
Can we lead with describing what a static file server is?  That is, why am I
building this at all?  (not because Heroku requires it, which is true, but
generally what role does this play in the greater scheme of things?)

https://chromiumcodereview.appspot.com/138823002/diff/660001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:694: ![Your tab appears under the Chrome
heading](images/tabslist.png)
this screenshot is too small, I can't see what you're pointing to :(

https://chromiumcodereview.appspot.com/138823002/diff/660001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:706: In Chrome on your compouter,
spelling

https://chromiumcodereview.appspot.com/138823002/diff/660001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:946: ##Step 6: Run the app online and on
mobile {#step-six}
what does "online and on mobile" mean?

[Shams, 2014-01-17 17:23:09]

A few small things (besides the fact I didn't get the phone part to work
completely). Overall, it looks good!

https://chromiumcodereview.appspot.com/138823002/diff/660001/src/site/codelab...
File src/site/codelabs/deploy/index.markdown (right):

https://chromiumcodereview.appspot.com/138823002/diff/660001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:216: ![Click the run
button](images/runtheapp.png)
It failed to run. I had to manually do a "pub get" .

https://chromiumcodereview.appspot.com/138823002/diff/660001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:260: this process generates minimized
JavaScript that
minimized JavaScript -> minified JavaScript

https://chromiumcodereview.appspot.com/138823002/diff/660001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:348: Built 8 files!
Minor nit. For me it said it built 10 files.

https://chromiumcodereview.appspot.com/138823002/diff/660001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:420: ##Step 3: Build a static server
{#step-three}
This step confused me. You actually provide the static server (in
bin/basic_http_server.dart) and this step walks through the code. Maybe add some
intro text that says. You need to build a static server, but we provided one for
you. Here is a walkthrough of the code.

Or something.  :)

Otherwise, I think I am supposed to be actively doing something here.

https://chromiumcodereview.appspot.com/138823002/diff/660001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:652: ##Step 4: Inspect your app on a
mobile device {#step-four}
As you know, this step didn't succeed for me using your loaner Nexus 4.

Some of the info in this step applies specifically to an Android phone. Some of
it applies to everyone (such as starting the server). If you could separate the
two, that would be better. Many people do not own Android phones and will skip
this step entirely.

https://chromiumcodereview.appspot.com/138823002/diff/660001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:707: click the Android icon at the right
side of the window
Maybe mention that the Android only appears if you are connected to the mobile
device.

https://chromiumcodereview.appspot.com/138823002/diff/660001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:784: ### <i class="fa fa-anchor"> </i>
Commit your changes to your local `deploy-codelab-master` git repo
This step surprised me. I didn't know I would have to create a Git repo. Maybe
introduce it a bit by saying that Heroku requires that you submit an app using a
Git repo. (If that is true, of course.)

https://chromiumcodereview.appspot.com/138823002/diff/660001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:827: $ heroku create
[[highlight]]myfirstdartappforheroku[[/highlight]] -s cedar
Having never used Heroku before, this didn't work. Maybe mention on the side
that you need to download the Heroku tools package and create a login.

[mem, 2014-01-17 21:33:58]

Integrated everybody's comments.

Can I weigh anchor and host the mizzen.... ?

mem

https://first-looksies-newcodelab-dot-dart-lang.appspot.com/codelabs/deploy/

https://chromiumcodereview.appspot.com/138823002/diff/660001/src/site/codelab...
File src/site/codelabs/deploy/index.markdown (right):

https://chromiumcodereview.appspot.com/138823002/diff/660001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:23: you need to put it on the internet
so that people can use it.
On 2014/01/17 00:07:23, sethladd wrote:
> s/internet/web

Done.

https://chromiumcodereview.appspot.com/138823002/diff/660001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:26: you learn to deploy an app to the
internet using the
On 2014/01/17 00:07:23, sethladd wrote:
> how about, "You will learn how to build a Dart app for deployment to web. You
> will then learn how to serve that app so browsers can access it. Finally, you
> will learn one way to deploy the app to the web."
> 
> In other words, can you descrive what they will learn as shown in your
diagram?

Done.

https://chromiumcodereview.appspot.com/138823002/diff/660001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:34: In this code lab, you deploy the
Pirate Badge app from the
On 2014/01/17 00:07:23, sethladd wrote:
> In this code lab leads two paragraphs

Done.

https://chromiumcodereview.appspot.com/138823002/diff/660001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:145: ##Step 1: Run the app in Dart
Editor {#step-one}
On 2014/01/17 00:07:23, sethladd wrote:
> Is it running in Dart Editor or Dartium?

Done.

https://chromiumcodereview.appspot.com/138823002/diff/660001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:216: ![Click the run
button](images/runtheapp.png)
On 2014/01/17 17:23:09, shaza wrote:
> It failed to run. I had to manually do a "pub get" .

Done.

https://chromiumcodereview.appspot.com/138823002/diff/660001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:260: this process generates minimized
JavaScript that
On 2014/01/17 17:23:09, shaza wrote:
> minimized JavaScript -> minified JavaScript

Done.

https://chromiumcodereview.appspot.com/138823002/diff/660001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:348: Built 8 files!
On 2014/01/17 17:23:09, shaza wrote:
> Minor nit. For me it said it built 10 files.

Done.

https://chromiumcodereview.appspot.com/138823002/diff/660001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:420: ##Step 3: Build a static server
{#step-three}
On 2014/01/17 17:23:09, shaza wrote:
> This step confused me. You actually provide the static server (in
> bin/basic_http_server.dart) and this step walks through the code. Maybe add
some
> intro text that says. You need to build a static server, but we provided one
for
> you. Here is a walkthrough of the code.
> 
> Or something.  :)
> 
> Otherwise, I think I am supposed to be actively doing something here.

Done.

https://chromiumcodereview.appspot.com/138823002/diff/660001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:422: Heroku requires that you provide a
static file server with your project.
On 2014/01/17 00:07:23, sethladd wrote:
> Can we lead with describing what a static file server is?  That is, why am I
> building this at all?  (not because Heroku requires it, which is true, but
> generally what role does this play in the greater scheme of things?)

Done.

https://chromiumcodereview.appspot.com/138823002/diff/660001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:652: ##Step 4: Inspect your app on a
mobile device {#step-four}
On 2014/01/17 17:23:09, shaza wrote:
> As you know, this step didn't succeed for me using your loaner Nexus 4.
> 
> Some of the info in this step applies specifically to an Android phone. Some
of
> it applies to everyone (such as starting the server). If you could separate
the
> two, that would be better. Many people do not own Android phones and will skip
> this step entirely.

Done.

https://chromiumcodereview.appspot.com/138823002/diff/660001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:694: ![Your tab appears under the Chrome
heading](images/tabslist.png)
On 2014/01/17 00:07:23, sethladd wrote:
> this screenshot is too small, I can't see what you're pointing to :(

Done.

https://chromiumcodereview.appspot.com/138823002/diff/660001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:706: In Chrome on your compouter,
On 2014/01/17 00:07:23, sethladd wrote:
> spelling

Done.

https://chromiumcodereview.appspot.com/138823002/diff/660001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:707: click the Android icon at the right
side of the window
On 2014/01/17 17:23:09, shaza wrote:
> Maybe mention that the Android only appears if you are connected to the mobile
> device.

Done.

https://chromiumcodereview.appspot.com/138823002/diff/660001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:784: ### <i class="fa fa-anchor"> </i>
Commit your changes to your local `deploy-codelab-master` git repo
On 2014/01/17 17:23:09, shaza wrote:
> This step surprised me. I didn't know I would have to create a Git repo. Maybe
> introduce it a bit by saying that Heroku requires that you submit an app using
a
> Git repo. (If that is true, of course.)

Done.

https://chromiumcodereview.appspot.com/138823002/diff/660001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:827: $ heroku create
[[highlight]]myfirstdartappforheroku[[/highlight]] -s cedar
On 2014/01/17 17:23:09, shaza wrote:
> Having never used Heroku before, this didn't work. Maybe mention on the side
> that you need to download the Heroku tools package and create a login.

Done.

https://chromiumcodereview.appspot.com/138823002/diff/660001/src/site/codelab...
src/site/codelabs/deploy/index.markdown:946: ##Step 6: Run the app online and on
mobile {#step-six}
On 2014/01/17 00:07:23, sethladd wrote:
> what does "online and on mobile" mean?

Done.

[mem, 2014-01-17 21:34:07]

Integrated everybody's comments.

Can I weigh anchor and hoist the mizzen.... ?

mem

https://first-looksies-newcodelab-dot-dart-lang.appspot.com/codelabs/deploy/

[mem, 2014-01-17 21:34:11]

Integrated everybody's comments.

Can I weigh anchor and hoist the mizzen.... ?

mem

https://first-looksies-newcodelab-dot-dart-lang.appspot.com/codelabs/deploy/

[mem, 2014-01-21 23:44:32]

Hi Kathy:
Can you take another look at this please?

Thanks.
mem

[mem, 2014-01-24 18:09:19]

Sorry to impose, but here is another revision.

Is this in shipshape? Do you tire of the pirate theme?

https://newcodelab-dot-dart-lang.appspot.com/codelabs/deploy/
mem

[sethladd, 2014-01-24 23:03:02]

https://chromiumcodereview.appspot.com/138823002/diff/1530001/src/site/codela...
File src/site/codelabs/deploy/index.markdown (right):

https://chromiumcodereview.appspot.com/138823002/diff/1530001/src/site/codela...
src/site/codelabs/deploy/index.markdown:25: Now, we switch from client-side
programming to server-side.
This sentence is very context-heavy. That is, what if I'm not switching now?
What if I did part 1 three weeks ago?

https://chromiumcodereview.appspot.com/138823002/diff/1530001/src/site/codela...
src/site/codelabs/deploy/index.markdown:39: For that, you need an app, a server,
and a host.
server is overloaded... I need a physical (or virtual) server and I need an HTTP
server.

as discussed:

web server
hosting service

https://chromiumcodereview.appspot.com/138823002/diff/1530001/src/site/codela...
src/site/codelabs/deploy/index.markdown:47: You can use any server to serve your
Dart app,
global: clarify server to web server

https://chromiumcodereview.appspot.com/138823002/diff/1530001/src/site/codela...
src/site/codelabs/deploy/index.markdown:49: runs on both the client and the
server, so you
this seems like a long sentence

https://chromiumcodereview.appspot.com/138823002/diff/1530001/src/site/codela...
src/site/codelabs/deploy/index.markdown:53: Dart also runs on Windows, Linux, or
Mac systems.
not sure we need the word 'also' here.

Should we mention the Dart VM here? I wonder if they know what "runs on the
server" means?

https://chromiumcodereview.appspot.com/138823002/diff/1530001/src/site/codela...
src/site/codelabs/deploy/index.markdown:55: * **Server**—In this code lab,
you learn how to build a server in Dart
clarify to web server

https://chromiumcodereview.appspot.com/138823002/diff/1530001/src/site/codela...
src/site/codelabs/deploy/index.markdown:77: * [Step 1: Run the app in
Dartium](#step-one)
global: qualify app as client app?

https://chromiumcodereview.appspot.com/138823002/diff/1530001/src/site/codela...
src/site/codelabs/deploy/index.markdown:159: are related to package
dependencies.
what are package dependencies?

suggestion: The packages directory contains links to 3rd party libraries. Those
libraries are defined as dependencies in the pubspec.yaml file. The pubspec.lock
file specifies the exact versions of the packages required by this app.

https://chromiumcodereview.appspot.com/138823002/diff/1530001/src/site/codela...
src/site/codelabs/deploy/index.markdown:165: * The `bin` directory contains the
code for a static file server.
The bin directory contains Dart scripts that run from the command line. For
example, scripts that run web servers live in bin.

https://chromiumcodereview.appspot.com/138823002/diff/1530001/src/site/codela...
src/site/codelabs/deploy/index.markdown:166: You can use the server for testing
and debugging your app
The first-order function of the server is to serve the app. You don't really use
it for testing and debugging. Besides, I don't think we should define the job of
the server here (since all we're doing is talking about the role of the bin
directory)

https://chromiumcodereview.appspot.com/138823002/diff/1530001/src/site/codela...
src/site/codelabs/deploy/index.markdown:212: ...
I really wanted to see a reference to the script that contains the app. Looking
at this, where is the app? :)

https://chromiumcodereview.appspot.com/138823002/diff/1530001/src/site/codela...
src/site/codelabs/deploy/index.markdown:309: {% prettify dart %}
Why is this important to building the app?

https://chromiumcodereview.appspot.com/138823002/diff/1530001/src/site/codela...
src/site/codelabs/deploy/index.markdown:346: In Dart Editor, expand the
top-level `packages` directory.
why is this important to building the app? that is, why talk about it now?

https://chromiumcodereview.appspot.com/138823002/diff/1530001/src/site/codela...
src/site/codelabs/deploy/index.markdown:463: A static file server is a
stand-alone application that listens
can you clarify that you can write dynamic HTTP servers with Dart? I don't want
them to get the impression that all we can do is statically serve files.

suggestion:

You can build full HTTP servers with Dart. The HTTP libraries and packages
support both serving static files and handling dynamic requests. For this code
lab, we focus on serving static files.

Something like that.

https://chromiumcodereview.appspot.com/138823002/diff/1530001/src/site/codela...
src/site/codelabs/deploy/index.markdown:470: because Heroku requires one for
deployment.
add: "Also, it's fun to serve your Dart client app with a server built with
Dart!" :)

https://chromiumcodereview.appspot.com/138823002/diff/1530001/src/site/codela...
src/site/codelabs/deploy/index.markdown:691: which is a special address that is
guaranteed to receive from any network socket.
long line.

also, receive what?

https://chromiumcodereview.appspot.com/138823002/diff/1530001/src/site/codela...
src/site/codelabs/deploy/index.markdown:697:   {% comment %} non-breaking
space required for bootstrap/markdown bogosity {% endcomment %}
long line

https://chromiumcodereview.appspot.com/138823002/diff/1530001/src/site/codela...
src/site/codelabs/deploy/index.markdown:713: Now, type `0.0.0.0:9999` in the URL
text field of any browser.
how about:  "Now, open `http://0.0.0.0:9999` in your browser.

https://chromiumcodereview.appspot.com/138823002/diff/1530001/src/site/codela...
src/site/codelabs/deploy/index.markdown:772: and  type the `0.0.0.0:9999` URL
into the URL text field.
"open http://0.0.0.0:9999 in your browser.

https://chromiumcodereview.appspot.com/138823002/diff/1530001/src/site/codela...
src/site/codelabs/deploy/index.markdown:805: on the mobile device.
can you double-clarify what's going on?

"You are now inspecting the client app running on your mobile device."

https://chromiumcodereview.appspot.com/138823002/diff/1530001/src/site/codela...
src/site/codelabs/deploy/index.markdown:815: Experiment by modifying the font
size or color.
clarify that you mean for them to use dev tools to change the style properties.
I sort of interpreted this as go back into my dart code and start this whole
process over.

https://chromiumcodereview.appspot.com/138823002/diff/1530001/src/site/codela...
src/site/codelabs/deploy/index.markdown:820: ### <i class="fa fa-anchor"> </i>
Save your changes
maybe drop this section? it sort of implies you can save the changes you made
with dev tools

https://chromiumcodereview.appspot.com/138823002/diff/1530001/src/site/codela...
src/site/codelabs/deploy/index.markdown:831: In this step, you deploy your
server and app to Heroku.
maybe talk about why heroku? heroku is a cloud hosting service which happens to
have a free tier and run arbitrary VMs which is why we're using it here today.

https://chromiumcodereview.appspot.com/138823002/diff/1530001/src/site/codela...
src/site/codelabs/deploy/index.markdown:840: [Getting Started with
Heroko](https://devcenter.heroku.com/articles/quickstart)
typo: heroku

https://chromiumcodereview.appspot.com/138823002/diff/1530001/src/site/codela...
src/site/codelabs/deploy/index.markdown:849: * Now you can deploy your app to
Heroku.
This seems like a status update, not a "what this is", which is how a lot of
other Key Information sections are written

https://chromiumcodereview.appspot.com/138823002/diff/1530001/src/site/codela...
src/site/codelabs/deploy/index.markdown:889: ### <i class="fa fa-anchor"> </i>
Commit your changes to your local `deploy-codelab` git repo
couple things to define:

what is git?
what is a git repo?
how do I get git?

https://chromiumcodereview.appspot.com/138823002/diff/1530001/src/site/codela...
src/site/codelabs/deploy/index.markdown:907: $
blank prompt?

https://chromiumcodereview.appspot.com/138823002/diff/1530001/src/site/codela...
src/site/codelabs/deploy/index.markdown:1038: $ heroku ps:scale  web=1
two spaces after scale

[mem, 2014-01-24 23:55:04]

https://newcodelab-dot-dart-lang.appspot.com/codelabs/deploy/

https://chromiumcodereview.appspot.com/138823002/diff/1530001/src/site/codela...
File src/site/codelabs/deploy/index.markdown (right):

https://chromiumcodereview.appspot.com/138823002/diff/1530001/src/site/codela...
src/site/codelabs/deploy/index.markdown:25: Now, we switch from client-side
programming to server-side.
On 2014/01/24 23:03:03, sethladd wrote:
> This sentence is very context-heavy. That is, what if I'm not switching now?
> What if I did part 1 three weeks ago?

Done.

https://chromiumcodereview.appspot.com/138823002/diff/1530001/src/site/codela...
src/site/codelabs/deploy/index.markdown:39: For that, you need an app, a server,
and a host.
On 2014/01/24 23:03:03, sethladd wrote:
> server is overloaded... I need a physical (or virtual) server and I need an
HTTP
> server.
> 
> as discussed:
> 
> web server
> hosting service

Done.

https://chromiumcodereview.appspot.com/138823002/diff/1530001/src/site/codela...
src/site/codelabs/deploy/index.markdown:47: You can use any server to serve your
Dart app,
On 2014/01/24 23:03:03, sethladd wrote:
> global: clarify server to web server

Done.

https://chromiumcodereview.appspot.com/138823002/diff/1530001/src/site/codela...
src/site/codelabs/deploy/index.markdown:49: runs on both the client and the
server, so you
On 2014/01/24 23:03:03, sethladd wrote:
> this seems like a long sentence

Done.

https://chromiumcodereview.appspot.com/138823002/diff/1530001/src/site/codela...
src/site/codelabs/deploy/index.markdown:53: Dart also runs on Windows, Linux, or
Mac systems.
On 2014/01/24 23:03:03, sethladd wrote:
> not sure we need the word 'also' here.
> 
> Should we mention the Dart VM here? I wonder if they know what "runs on the
> server" means?

Done.

https://chromiumcodereview.appspot.com/138823002/diff/1530001/src/site/codela...
src/site/codelabs/deploy/index.markdown:55: * **Server**—In this code lab,
you learn how to build a server in Dart
On 2014/01/24 23:03:03, sethladd wrote:
> clarify to web server

Done.

https://chromiumcodereview.appspot.com/138823002/diff/1530001/src/site/codela...
src/site/codelabs/deploy/index.markdown:77: * [Step 1: Run the app in
Dartium](#step-one)
On 2014/01/24 23:03:03, sethladd wrote:
> global: qualify app as client app?

Done.

https://chromiumcodereview.appspot.com/138823002/diff/1530001/src/site/codela...
src/site/codelabs/deploy/index.markdown:159: are related to package
dependencies.
On 2014/01/24 23:03:03, sethladd wrote:
> what are package dependencies?
> 
> suggestion: The packages directory contains links to 3rd party libraries.
Those
> libraries are defined as dependencies in the pubspec.yaml file. The
pubspec.lock
> file specifies the exact versions of the packages required by this app.

Done.

https://chromiumcodereview.appspot.com/138823002/diff/1530001/src/site/codela...
src/site/codelabs/deploy/index.markdown:165: * The `bin` directory contains the
code for a static file server.
On 2014/01/24 23:03:03, sethladd wrote:
> The bin directory contains Dart scripts that run from the command line. For
> example, scripts that run web servers live in bin.

Done.

https://chromiumcodereview.appspot.com/138823002/diff/1530001/src/site/codela...
src/site/codelabs/deploy/index.markdown:166: You can use the server for testing
and debugging your app
On 2014/01/24 23:03:03, sethladd wrote:
> The first-order function of the server is to serve the app. You don't really
use
> it for testing and debugging. Besides, I don't think we should define the job
of
> the server here (since all we're doing is talking about the role of the bin
> directory)

Done.

https://chromiumcodereview.appspot.com/138823002/diff/1530001/src/site/codela...
src/site/codelabs/deploy/index.markdown:212: ...
On 2014/01/24 23:03:03, sethladd wrote:
> I really wanted to see a reference to the script that contains the app.
Looking
> at this, where is the app? :)

Done.

https://chromiumcodereview.appspot.com/138823002/diff/1530001/src/site/codela...
src/site/codelabs/deploy/index.markdown:309: {% prettify dart %}
On 2014/01/24 23:03:03, sethladd wrote:
> Why is this important to building the app?

Done.

https://chromiumcodereview.appspot.com/138823002/diff/1530001/src/site/codela...
src/site/codelabs/deploy/index.markdown:346: In Dart Editor, expand the
top-level `packages` directory.
On 2014/01/24 23:03:03, sethladd wrote:
> why is this important to building the app? that is, why talk about it now?

Done.

https://chromiumcodereview.appspot.com/138823002/diff/1530001/src/site/codela...
src/site/codelabs/deploy/index.markdown:463: A static file server is a
stand-alone application that listens
On 2014/01/24 23:03:03, sethladd wrote:
> can you clarify that you can write dynamic HTTP servers with Dart? I don't
want
> them to get the impression that all we can do is statically serve files.
> 
> suggestion:
> 
> You can build full HTTP servers with Dart. The HTTP libraries and packages
> support both serving static files and handling dynamic requests. For this code
> lab, we focus on serving static files.
> 
> Something like that.

Done.

https://chromiumcodereview.appspot.com/138823002/diff/1530001/src/site/codela...
src/site/codelabs/deploy/index.markdown:470: because Heroku requires one for
deployment.
On 2014/01/24 23:03:03, sethladd wrote:
> add: "Also, it's fun to serve your Dart client app with a server built with
> Dart!" :)

Done.

https://chromiumcodereview.appspot.com/138823002/diff/1530001/src/site/codela...
src/site/codelabs/deploy/index.markdown:691: which is a special address that is
guaranteed to receive from any network socket.
On 2014/01/24 23:03:03, sethladd wrote:
> long line.
> 
> also, receive what?

Done.

https://chromiumcodereview.appspot.com/138823002/diff/1530001/src/site/codela...
src/site/codelabs/deploy/index.markdown:697:   {% comment %} non-breaking
space required for bootstrap/markdown bogosity {% endcomment %}
On 2014/01/24 23:03:03, sethladd wrote:
> long line

Done.

https://chromiumcodereview.appspot.com/138823002/diff/1530001/src/site/codela...
src/site/codelabs/deploy/index.markdown:713: Now, type `0.0.0.0:9999` in the URL
text field of any browser.
On 2014/01/24 23:03:03, sethladd wrote:
> how about:  "Now, open `http://0.0.0.0:9999` in your browser.

Done.

https://chromiumcodereview.appspot.com/138823002/diff/1530001/src/site/codela...
src/site/codelabs/deploy/index.markdown:772: and  type the `0.0.0.0:9999` URL
into the URL text field.
On 2014/01/24 23:03:03, sethladd wrote:
> "open http://0.0.0.0:9999 in your browser.

Done.

https://chromiumcodereview.appspot.com/138823002/diff/1530001/src/site/codela...
src/site/codelabs/deploy/index.markdown:805: on the mobile device.
On 2014/01/24 23:03:03, sethladd wrote:
> can you double-clarify what's going on?
> 
> "You are now inspecting the client app running on your mobile device."

Done.

https://chromiumcodereview.appspot.com/138823002/diff/1530001/src/site/codela...
src/site/codelabs/deploy/index.markdown:815: Experiment by modifying the font
size or color.
On 2014/01/24 23:03:03, sethladd wrote:
> clarify that you mean for them to use dev tools to change the style
properties.
> I sort of interpreted this as go back into my dart code and start this whole
> process over.

Done.

https://chromiumcodereview.appspot.com/138823002/diff/1530001/src/site/codela...
src/site/codelabs/deploy/index.markdown:820: ### <i class="fa fa-anchor"> </i>
Save your changes
On 2014/01/24 23:03:03, sethladd wrote:
> maybe drop this section? it sort of implies you can save the changes you made
> with dev tools

Done.

https://chromiumcodereview.appspot.com/138823002/diff/1530001/src/site/codela...
src/site/codelabs/deploy/index.markdown:831: In this step, you deploy your
server and app to Heroku.
On 2014/01/24 23:03:03, sethladd wrote:
> maybe talk about why heroku? heroku is a cloud hosting service which happens
to
> have a free tier and run arbitrary VMs which is why we're using it here today.

Done.

https://chromiumcodereview.appspot.com/138823002/diff/1530001/src/site/codela...
src/site/codelabs/deploy/index.markdown:840: [Getting Started with
Heroko](https://devcenter.heroku.com/articles/quickstart)
On 2014/01/24 23:03:03, sethladd wrote:
> typo: heroku

Done.

https://chromiumcodereview.appspot.com/138823002/diff/1530001/src/site/codela...
src/site/codelabs/deploy/index.markdown:849: * Now you can deploy your app to
Heroku.
On 2014/01/24 23:03:03, sethladd wrote:
> This seems like a status update, not a "what this is", which is how a lot of
> other Key Information sections are written

Done.

https://chromiumcodereview.appspot.com/138823002/diff/1530001/src/site/codela...
src/site/codelabs/deploy/index.markdown:889: ### <i class="fa fa-anchor"> </i>
Commit your changes to your local `deploy-codelab` git repo
On 2014/01/24 23:03:03, sethladd wrote:
> couple things to define:
> 
> what is git?
> what is a git repo?
> how do I get git?

Done.

https://chromiumcodereview.appspot.com/138823002/diff/1530001/src/site/codela...
src/site/codelabs/deploy/index.markdown:907: $
On 2014/01/24 23:03:03, sethladd wrote:
> blank prompt?

Done.

https://chromiumcodereview.appspot.com/138823002/diff/1530001/src/site/codela...
src/site/codelabs/deploy/index.markdown:1038: $ heroku ps:scale  web=1
On 2014/01/24 23:03:03, sethladd wrote:
> two spaces after scale

Done.

[sethladd, 2014-01-24 23:59:51]

lgtm

ship it!

[mem, 2014-01-25 00:09:29]

Committed patchset #8 manually as r28edfdd (presubmit successful).

[Kathy Walrath, 2014-01-25 00:42:08]

Some comments, too late (but you can get 'em next time).

https://chromiumcodereview.appspot.com/138823002/diff/1810001/src/site/codela...
File src/site/codelabs/deploy/index.markdown (right):

https://chromiumcodereview.appspot.com/138823002/diff/1810001/src/site/codela...
src/site/codelabs/deploy/index.markdown:49: But Dart runs on the server-side as
well as on the client-side,
Starting this sentence with "But" is awkward, and the connection to the "so"
part is unclear. Rewrite? (sorry!) Maybe "Because"?

"on the client/server-side" seems wrong. First, I wouldn't hyphenate it, since
it's not an adjective. Maybe: "Because Dart can run on the server side, as well
as on the client side, you can...

https://chromiumcodereview.appspot.com/138823002/diff/1810001/src/site/codela...
src/site/codelabs/deploy/index.markdown:309: The packages listed under
dependencies *must* be installed
Take out the passive voice. It's unclear who's doing this installation. Maybe:

The dependencies section lists the packages that this app requires. The pub
command installs these packages...

https://chromiumcodereview.appspot.com/138823002/diff/1810001/src/site/codela...
src/site/codelabs/deploy/index.markdown:782: ### <i class="fa fa-anchor"> </i>
Bring up Devices page
up -> up the

https://chromiumcodereview.appspot.com/138823002/diff/1810001/src/site/codela...
src/site/codelabs/deploy/index.markdown:790: then the mobile device or your
computer is not properly connected or setup.
This isn't true as of M32. You don't need the extension to be able to connect to
DevTools. I never saw the Android icon, and I could connect just fine.

https://chromiumcodereview.appspot.com/138823002/diff/1810001/src/site/codela...
src/site/codelabs/deploy/index.markdown:896: [Pro Git
book](http://git-scm.com/downloads).
delete the "."

https://chromiumcodereview.appspot.com/138823002/diff/1810001/src/site/codela...
src/site/codelabs/deploy/index.markdown:896: [Pro Git
book](http://git-scm.com/downloads).
I got confused about the "book" reference vs. the git download. The website
isn't called "Pro Git book". maybe:

Refer to the [git website](...) for ...

https://chromiumcodereview.appspot.com/138823002/diff/1810001/src/site/codela...
src/site/codelabs/deploy/index.markdown:1118: ##What next? {#what-next}
I like moving this here.

[mem, 2014-01-29 17:53:48]

final comments that didn't get sent before

https://chromiumcodereview.appspot.com/138823002/diff/1810001/src/site/codela...
File src/site/codelabs/deploy/index.markdown (right):

https://chromiumcodereview.appspot.com/138823002/diff/1810001/src/site/codela...
src/site/codelabs/deploy/index.markdown:49: But Dart runs on the server-side as
well as on the client-side,
On 2014/01/25 00:42:09, Kathy Walrath wrote:
> Starting this sentence with "But" is awkward, and the connection to the "so"
> part is unclear. Rewrite? (sorry!) Maybe "Because"?
> 
> "on the client/server-side" seems wrong. First, I wouldn't hyphenate it, since
> it's not an adjective. Maybe: "Because Dart can run on the server side, as
well
> as on the client side, you can...

Done.

https://chromiumcodereview.appspot.com/138823002/diff/1810001/src/site/codela...
src/site/codelabs/deploy/index.markdown:309: The packages listed under
dependencies *must* be installed
On 2014/01/25 00:42:09, Kathy Walrath wrote:
> Take out the passive voice. It's unclear who's doing this installation. Maybe:
> 
> The dependencies section lists the packages that this app requires. The pub
> command installs these packages...

Done.

https://chromiumcodereview.appspot.com/138823002/diff/1810001/src/site/codela...
src/site/codelabs/deploy/index.markdown:782: ### <i class="fa fa-anchor"> </i>
Bring up Devices page
On 2014/01/25 00:42:09, Kathy Walrath wrote:
> up -> up the

Done.

https://chromiumcodereview.appspot.com/138823002/diff/1810001/src/site/codela...
src/site/codelabs/deploy/index.markdown:790: then the mobile device or your
computer is not properly connected or setup.
Done.

I stole some language from the Remote Debugging site.

On 2014/01/25 00:42:09, Kathy Walrath wrote:
> This isn't true as of M32. You don't need the extension to be able to connect
to
> DevTools. I never saw the Android icon, and I could connect just fine.

https://chromiumcodereview.appspot.com/138823002/diff/1810001/src/site/codela...
src/site/codelabs/deploy/index.markdown:896: [Pro Git
book](http://git-scm.com/downloads).
On 2014/01/25 00:42:09, Kathy Walrath wrote:
> I got confused about the "book" reference vs. the git download. The website
> isn't called "Pro Git book". maybe:
> 
> Refer to the [git website](...) for ...

Done.

https://chromiumcodereview.appspot.com/138823002/diff/1810001/src/site/codela...
src/site/codelabs/deploy/index.markdown:896: [Pro Git
book](http://git-scm.com/downloads).
On 2014/01/25 00:42:09, Kathy Walrath wrote:
> delete the "."

Done.

https://chromiumcodereview.appspot.com/138823002/diff/1810001/src/site/codela...
src/site/codelabs/deploy/index.markdown:1118: ##What next? {#what-next}
On 2014/01/25 00:42:09, Kathy Walrath wrote:
> I like moving this here.

Done.