Extract common HTML from oobe.html/login.html.

Extract common HTML from oobe.html/login.html.

By the way, using grit as a template engine is painfully awkward :(

BUG=232048
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195155

[dconnelly, 2013-04-17 15:31:04]

I'm not sure this is the best approach, but I couldn't think of a better one. 
It would be so much easier with a more intelligent templating mechanism.  If
anyone has a clever suggestion that makes it less awkward I would love to hear
one.

[dzhioev (left Google), 2013-04-18 09:28:25]

On 2013/04/17 15:31:04, dconnelly wrote:
> I'm not sure this is the best approach, but I couldn't think of a better one. 
> It would be so much easier with a more intelligent templating mechanism.  If
> anyone has a clever suggestion that makes it less awkward I would love to hear
> one.

I can't find where login_screens.html included?

[Nikita (slow), 2013-04-18 09:29:40]

lgtm, looks much cleaner now, thanks!

Please run trybots: linux_chromeos, cros_daisy, cros_amd64, cros_x86

https://codereview.chromium.org/13881017/diff/1/chrome/browser/resources/chro...
File chrome/browser/resources/chromeos/login/screen_container.html (right):

https://codereview.chromium.org/13881017/diff/1/chrome/browser/resources/chro...
chrome/browser/resources/chromeos/login/screen_container.html:7: <img
src="chrome://theme/IDR_PRODUCT_LOGO" alt="">
nit: alt attribute could be dropped

[dzhioev (left Google), 2013-04-18 09:33:30]

https://codereview.chromium.org/13881017/diff/1/chrome/browser/resources/chro...
File chrome/browser/resources/chromeos/login/screen_container.html (right):

https://codereview.chromium.org/13881017/diff/1/chrome/browser/resources/chro...
chrome/browser/resources/chromeos/login/screen_container.html:7: <img
src="chrome://theme/IDR_PRODUCT_LOGO" alt="">
On 2013/04/18 09:29:40, Nikita Kostylev wrote:
> nit: alt attribute could be dropped
No, alt attribute is required for img in html5. But you can simply use empty
attribute <img alt ... > instead of <img alt="">.

[Nikita (slow), 2013-04-18 09:36:55]

https://codereview.chromium.org/13881017/diff/1/chrome/browser/resources/chro...
File chrome/browser/resources/chromeos/login/screen_container.html (right):

https://codereview.chromium.org/13881017/diff/1/chrome/browser/resources/chro...
chrome/browser/resources/chromeos/login/screen_container.html:7: <img
src="chrome://theme/IDR_PRODUCT_LOGO" alt="">
On 2013/04/18 09:33:30, dzhioev wrote:
> On 2013/04/18 09:29:40, Nikita Kostylev wrote:
> > nit: alt attribute could be dropped
> No, alt attribute is required for img in html5. But you can simply use empty
> attribute <img alt ... > instead of <img alt="">.

Thanks for clarification.

[dconnelly, 2013-04-18 12:50:40]

On 2013/04/18 09:33:30, dzhioev wrote:
>
https://codereview.chromium.org/13881017/diff/1/chrome/browser/resources/chro...
> File chrome/browser/resources/chromeos/login/screen_container.html (right):
> 
>
https://codereview.chromium.org/13881017/diff/1/chrome/browser/resources/chro...
> chrome/browser/resources/chromeos/login/screen_container.html:7: <img
> src="chrome://theme/IDR_PRODUCT_LOGO" alt="">
> On 2013/04/18 09:29:40, Nikita Kostylev wrote:
> > nit: alt attribute could be dropped
> No, alt attribute is required for img in html5. But you can simply use empty
> attribute <img alt ... > instead of <img alt="">.

Yeah, good catch.  This sucks.  I made oobe_screen_container.html and
login_screen_container.html now.  Hopefully I can patch grit to handle this more
intelligently and then I'll unify them.

[dconnelly, 2013-04-18 12:50:46]

https://codereview.chromium.org/13881017/diff/1/chrome/browser/resources/chro...
File chrome/browser/resources/chromeos/login/screen_container.html (right):

https://codereview.chromium.org/13881017/diff/1/chrome/browser/resources/chro...
chrome/browser/resources/chromeos/login/screen_container.html:7: <img
src="chrome://theme/IDR_PRODUCT_LOGO" alt="">
On 2013/04/18 09:33:30, dzhioev wrote:
> On 2013/04/18 09:29:40, Nikita Kostylev wrote:
> > nit: alt attribute could be dropped
> No, alt attribute is required for img in html5. But you can simply use empty
> attribute <img alt ... > instead of <img alt="">.

Done.

[dzhioev (left Google), 2013-04-18 13:16:46]

On 2013/04/18 12:50:46, dconnelly wrote:
>
https://codereview.chromium.org/13881017/diff/1/chrome/browser/resources/chro...
> File chrome/browser/resources/chromeos/login/screen_container.html (right):
> 
>
https://codereview.chromium.org/13881017/diff/1/chrome/browser/resources/chro...
> chrome/browser/resources/chromeos/login/screen_container.html:7: <img
> src="chrome://theme/IDR_PRODUCT_LOGO" alt="">
> On 2013/04/18 09:33:30, dzhioev wrote:
> > On 2013/04/18 09:29:40, Nikita Kostylev wrote:
> > > nit: alt attribute could be dropped
> > No, alt attribute is required for img in html5. But you can simply use empty
> > attribute <img alt ... > instead of <img alt="">.
> 
> Done.

lgtm

[commit-bot: I haz the power, 2013-04-19 08:20:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dconnelly@chromium.org/13881017/17001

[commit-bot: I haz the power, 2013-04-19 13:17:18]

Change committed as 195155