Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tests_lit/parse_errs/symtab-after-fcn.test

Issue 1387963002: Make sure that all globals are internal, except for "start" functions. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Fix nit. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tests_lit/llvm2ice_tests/nacl-mem-intrinsics.ll ('K') | « tests_lit/parse_errs/insertelt-wrong-type.test ('k') | tests_lit/reader_tests/alloca.ll » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests_lit/parse_errs/symtab-after-fcn.test
diff --git a/tests_lit/parse_errs/symtab-after-fcn.test b/tests_lit/parse_errs/symtab-after-fcn.test
index 4e519f1b2c59cf23007266b70bbb830e918dcabd..a74bbd2d3df9d03c4fc81faadc895d9336ba3436 100644
--- a/tests_lit/parse_errs/symtab-after-fcn.test
+++ b/tests_lit/parse_errs/symtab-after-fcn.test
@@ -3,7 +3,8 @@
; REQUIRES: no_minimal_build
; RUN: not %pnacl_sz -bitcode-as-text %p/Inputs/symtab-after-fcn.tbc \
-; RUN: -bitcode-format=pnacl -notranslate -build-on-read 2>&1 \
+; RUN: -bitcode-format=pnacl -notranslate -build-on-read \
+; RUN: -allow-externally-defined-symbols 2>&1 \
; RUN: | FileCheck %s
; CHECK: Module valuesymtab not allowed after function blocks
« tests_lit/llvm2ice_tests/nacl-mem-intrinsics.ll ('K') | « tests_lit/parse_errs/insertelt-wrong-type.test ('k') | tests_lit/reader_tests/alloca.ll » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698