tests_lit/parse_errs/bad-var-fwdref.test - Issue 1387963002: Make sure that all globals are internal, except for "start" functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests_lit/parse_errs/bad-var-fwdref.test

Issue 1387963002: Make sure that all globals are internal, except for "start" functions. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Fix nit. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tests_lit/llvm2ice_tests/nacl-mem-intrinsics.ll ('K') | « tests_lit/parse_errs/bad-switch-case.test ('k') | tests_lit/parse_errs/call-fcn-bad-param-type.ll » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tests_lit/parse_errs/bad-var-fwdref.test

diff --git a/tests_lit/parse_errs/bad-var-fwdref.test b/tests_lit/parse_errs/bad-var-fwdref.test

index a23dc075845ca3b57107762d098610cf8a11d4ba..ebf20da523045896c86b191f92d6be74aa480c91 100644

--- a/tests_lit/parse_errs/bad-var-fwdref.test

+++ b/tests_lit/parse_errs/bad-var-fwdref.test

@@ -3,7 +3,8 @@

; REQUIRES: no_minimal_build

; RUN: not %pnacl_sz -bitcode-as-text %p/Inputs/bad-var-fwdref.tbc \

-; RUN: -bitcode-format=pnacl -notranslate -no-ir-gen -build-on-read 2>&1 \

+; RUN: -bitcode-format=pnacl -notranslate -no-ir-gen -build-on-read \

+; RUN: -allow-externally-defined-symbols 2>&1 \

; RUN: | FileCheck %s

; CHECK: Forward reference @3105555534 too big. Have 1 globals and function contains 16 bytes