Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tests_lit/llvm2ice_tests/reorder-pooled-constants.ll

Issue 1387963002: Make sure that all globals are internal, except for "start" functions. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Fix nit. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tests_lit/llvm2ice_tests/nacl-mem-intrinsics.ll ('K') | « tests_lit/llvm2ice_tests/reorder-functions.ll ('k') | tests_lit/llvm2ice_tests/return_immediates.ll » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests_lit/llvm2ice_tests/reorder-pooled-constants.ll
diff --git a/tests_lit/llvm2ice_tests/reorder-pooled-constants.ll b/tests_lit/llvm2ice_tests/reorder-pooled-constants.ll
index ce53ea14f8dfff6d0707c081a81899ca25d94f5b..4bc3c20a2ffbad50d051753168a1409f022d598a 100644
--- a/tests_lit/llvm2ice_tests/reorder-pooled-constants.ll
+++ b/tests_lit/llvm2ice_tests/reorder-pooled-constants.ll
@@ -3,11 +3,11 @@
; RUN: %p2i --assemble --disassemble --filetype=obj --dis-flags=-s \
; RUN: --target x8632 -i %s --args -sz-seed=1 -O2 -reorder-pooled-constants \
-; RUN: | FileCheck %s --check-prefix=X86
+; RUN: -allow-externally-defined-symbols | FileCheck %s --check-prefix=X86
; RUN: %p2i --assemble --disassemble --filetype=obj --dis-flags=-s \
; RUN: --target x8632 -i %s --args -sz-seed=1 -Om1 -reorder-pooled-constants \
-; RUN: | FileCheck %s --check-prefix=X86
+; RUN: -allow-externally-defined-symbols | FileCheck %s --check-prefix=X86
@__init_array_start = internal constant [0 x i8] zeroinitializer, align 4
@__fini_array_start = internal constant [0 x i8] zeroinitializer, align 4
« tests_lit/llvm2ice_tests/nacl-mem-intrinsics.ll ('K') | « tests_lit/llvm2ice_tests/reorder-functions.ll ('k') | tests_lit/llvm2ice_tests/return_immediates.ll » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698