tests_lit/llvm2ice_tests/64bit.pnacl.ll - Issue 1387963002: Make sure that all globals are internal, except for "start" functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests_lit/llvm2ice_tests/64bit.pnacl.ll

Issue 1387963002: Make sure that all globals are internal, except for "start" functions. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Fix nit. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests_lit/llvm2ice_tests/64bit.pnacl.ll

diff --git a/tests_lit/llvm2ice_tests/64bit.pnacl.ll b/tests_lit/llvm2ice_tests/64bit.pnacl.ll

index f6c30fa21990db3a2d898f8fb1872ef32294feec..3807ba4c5b27387a62133cdfa280f1a7eed62ed2 100644

--- a/tests_lit/llvm2ice_tests/64bit.pnacl.ll

+++ b/tests_lit/llvm2ice_tests/64bit.pnacl.ll

@@ -3,11 +3,11 @@

; i32 operations on x86-32.

; RUN: %if --need=target_X8632 --command %p2i --filetype=obj --disassemble \

-; RUN: --target x8632 -i %s --args -O2 \

+; RUN: --target x8632 -i %s --args -O2 -allow-externally-defined-symbols \

; RUN: | %if --need=target_X8632 --command FileCheck %s

; RUN: %if --need=target_X8632 --command %p2i --filetype=obj --disassemble \

-; RUN: --target x8632 -i %s --args -Om1 \

+; RUN: --target x8632 -i %s --args -Om1 -allow-externally-defined-symbols \

; RUN: | %if --need=target_X8632 --command FileCheck --check-prefix=OPTM1 %s

; TODO(jvoung): Stop skipping unimplemented parts (via --skip-unimplemented)

@@ -16,11 +16,13 @@

; RUN: %if --need=target_ARM32 --need=allow_dump \

; RUN: --command %p2i --filetype=asm --assemble \

; RUN: --disassemble --target arm32 -i %s --args -O2 --skip-unimplemented \

+; RUN: -allow-externally-defined-symbols \

; RUN: | %if --need=target_ARM32 --need=allow_dump \

; RUN: --command FileCheck --check-prefix ARM32 %s

; RUN: %if --need=target_ARM32 --need=allow_dump \

; RUN: --command %p2i --filetype=asm --assemble --disassemble --target arm32 \

; RUN: -i %s --args -Om1 --skip-unimplemented \

+; RUN: -allow-externally-defined-symbols \

; RUN: | %if --need=target_ARM32 --need=allow_dump \

; RUN: --command FileCheck --check-prefix ARM32 %s

« no previous file with comments | « tests_lit/assembler/x86/sandboxing.ll ('k') | tests_lit/llvm2ice_tests/8bit.pnacl.ll » ('j') | tests_lit/llvm2ice_tests/nacl-mem-intrinsics.ll » ('J')