Make sure that all globals are internal, except for "start" functions.

unittest/IceParseInstsTest.cpp

 //===- unittest/IceParseInstsTest.cpp - test instruction errors -----------===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 
 #include <string>
@@ skipping 26 matching lines @@
 /// Test how we report a call arg that refers to nonexistent call argument
 TEST(IceParseInstsTest, NonexistentCallArg) {
   const uint64_t BitcodeRecords[] = {
     1, naclbitc::BLK_CODE_ENTER, naclbitc::MODULE_BLOCK_ID, 2, Terminator,
     1, naclbitc::BLK_CODE_ENTER, naclbitc::TYPE_BLOCK_ID_NEW, 2, Terminator,
     3, naclbitc::TYPE_CODE_NUMENTRY, 3, Terminator,
     3, naclbitc::TYPE_CODE_INTEGER, 32, Terminator,
     3, naclbitc::TYPE_CODE_VOID, Terminator,
     3, naclbitc::TYPE_CODE_FUNCTION, 0, 1, 0, 0, Terminator,
     0, naclbitc::BLK_CODE_EXIT, Terminator,
-    3, naclbitc::MODULE_CODE_FUNCTION, 2, 0, 1, 0, Terminator,
-    3, naclbitc::MODULE_CODE_FUNCTION, 2, 0, 0, 0, Terminator,
+    3, naclbitc::MODULE_CODE_FUNCTION, 2, 0, 1, 3, Terminator,
+    3, naclbitc::MODULE_CODE_FUNCTION, 2, 0, 0, 3, Terminator,
     1, naclbitc::BLK_CODE_ENTER, naclbitc::FUNCTION_BLOCK_ID, 2, Terminator,
     3, naclbitc::FUNC_CODE_DECLAREBLOCKS, 1, Terminator,
       // Note: 100 is a bad value index in next line.
     3, naclbitc::FUNC_CODE_INST_CALL, 0, 4, 2, 100, Terminator,
     3, naclbitc::FUNC_CODE_INST_RET, Terminator,
     0, naclbitc::BLK_CODE_EXIT, Terminator,
     0, naclbitc::BLK_CODE_EXIT, Terminator
   };
 
   // Show bitcode objdump for BitcodeRecords.
@@ skipping 19 matching lines @@
 TEST(IceParseInstsTests, AllocaAlignment) {
   const uint64_t BitcodeRecords[] = {
     1, naclbitc::BLK_CODE_ENTER, naclbitc::MODULE_BLOCK_ID, 2, Terminator,
     1,   naclbitc::BLK_CODE_ENTER, naclbitc::TYPE_BLOCK_ID_NEW, 2, Terminator,
     3,     naclbitc::TYPE_CODE_NUMENTRY, 4, Terminator,
     3,     naclbitc::TYPE_CODE_INTEGER, 32, Terminator,
     3,     naclbitc::TYPE_CODE_VOID, Terminator,
     3,     naclbitc::TYPE_CODE_FUNCTION, 0, 1, 0, Terminator,
     3,     naclbitc::TYPE_CODE_INTEGER, 8, Terminator,
     0,   naclbitc::BLK_CODE_EXIT, Terminator,
-    3,   naclbitc::MODULE_CODE_FUNCTION, 2, 0, 0, 0, Terminator,
+    3,   naclbitc::MODULE_CODE_FUNCTION, 2, 0, 0, 3, Terminator,
     1,   naclbitc::BLK_CODE_ENTER, naclbitc::FUNCTION_BLOCK_ID, 2, Terminator,
     3,     naclbitc::FUNC_CODE_DECLAREBLOCKS, 1, Terminator,
     3,     naclbitc::FUNC_CODE_INST_ALLOCA, 1, getEncAlignPower(0), Terminator,
     3,     naclbitc::FUNC_CODE_INST_RET, Terminator,
     0,   naclbitc::BLK_CODE_EXIT, Terminator,
     0, naclbitc::BLK_CODE_EXIT, Terminator};
 
   const uint64_t ReplaceIndex = 11; // index for FUNC_CODE_INST_ALLOCA
 
   // Show text when alignment is 1.
@@ skipping 46 matching lines @@
 
 // Test how we recognize alignments in load i32 instructions.
 TEST(IceParseInstsTests, LoadI32Alignment) {
   const uint64_t BitcodeRecords[] = {
     1, naclbitc::BLK_CODE_ENTER, naclbitc::MODULE_BLOCK_ID, 2, Terminator,
     1,   naclbitc::BLK_CODE_ENTER, naclbitc::TYPE_BLOCK_ID_NEW, 2, Terminator,
     3,     naclbitc::TYPE_CODE_NUMENTRY, 2, Terminator,
     3,     naclbitc::TYPE_CODE_INTEGER, 32, Terminator,
     3,     naclbitc::TYPE_CODE_FUNCTION, 0, 0, 0, Terminator,
     0,   naclbitc::BLK_CODE_EXIT, Terminator,
-    3,   naclbitc::MODULE_CODE_FUNCTION, 1, 0, 0, 0, Terminator,
+    3,   naclbitc::MODULE_CODE_FUNCTION, 1, 0, 0, 3, Terminator,
     1,   naclbitc::BLK_CODE_ENTER, naclbitc::FUNCTION_BLOCK_ID, 2, Terminator,
     3,     naclbitc::FUNC_CODE_DECLAREBLOCKS, 1, Terminator,
     3,     naclbitc::FUNC_CODE_INST_LOAD, 1, getEncAlignPower(0), 0, Terminator,
     3,     naclbitc::FUNC_CODE_INST_RET, 1, Terminator,
     0,   naclbitc::BLK_CODE_EXIT, Terminator,
     0, naclbitc::BLK_CODE_EXIT, Terminator};
 
   const uint64_t ReplaceIndex = 9; // index for FUNC_CODE_INST_LOAD
 
   // Show text when alignment is 1.
@@ skipping 61 matching lines @@
 // Test how we recognize alignments in load float instructions.
 TEST(IceParseInstsTests, LoadFloatAlignment) {
   const uint64_t BitcodeRecords[] = {
     1, naclbitc::BLK_CODE_ENTER, naclbitc::MODULE_BLOCK_ID, 2, Terminator,
     1,   naclbitc::BLK_CODE_ENTER, naclbitc::TYPE_BLOCK_ID_NEW, 2, Terminator,
     3,     naclbitc::TYPE_CODE_NUMENTRY, 3, Terminator,
     3,     naclbitc::TYPE_CODE_FLOAT, Terminator,
     3,     naclbitc::TYPE_CODE_INTEGER, 32, Terminator,
     3,     naclbitc::TYPE_CODE_FUNCTION, 0, 0, 1, Terminator,
     0,   naclbitc::BLK_CODE_EXIT, Terminator,
-    3,   naclbitc::MODULE_CODE_FUNCTION, 2, 0, 0, 0, Terminator,
+    3,   naclbitc::MODULE_CODE_FUNCTION, 2, 0, 0, 3, Terminator,
     1,   naclbitc::BLK_CODE_ENTER, naclbitc::FUNCTION_BLOCK_ID, 2, Terminator,
     3,     naclbitc::FUNC_CODE_DECLAREBLOCKS, 1, Terminator,
     3,     naclbitc::FUNC_CODE_INST_LOAD, 1, getEncAlignPower(0), 0, Terminator,
     3,     naclbitc::FUNC_CODE_INST_RET, 1, Terminator,
     0,   naclbitc::BLK_CODE_EXIT, Terminator,
     0, naclbitc::BLK_CODE_EXIT, Terminator};
 
   const uint64_t ReplaceIndex = 10; // index for FUNC_CODE_INST_LOAD
 
   // Show text when alignment is 1.
@@ skipping 60 matching lines @@
 // Test how we recognize alignments in store instructions.
 TEST(NaClParseInstsTests, StoreAlignment) {
   const uint64_t BitcodeRecords[] = {
   1, naclbitc::BLK_CODE_ENTER, naclbitc::MODULE_BLOCK_ID, 2, Terminator,
   1,   naclbitc::BLK_CODE_ENTER, naclbitc::TYPE_BLOCK_ID_NEW, 2, Terminator,
   3,     naclbitc::TYPE_CODE_NUMENTRY, 3, Terminator,
   3,     naclbitc::TYPE_CODE_FLOAT, Terminator,
   3,     naclbitc::TYPE_CODE_INTEGER, 32, Terminator,
   3,     naclbitc::TYPE_CODE_FUNCTION, 0, 0, 1, 0, Terminator,
   0,   naclbitc::BLK_CODE_EXIT, Terminator,
-  3,   naclbitc::MODULE_CODE_FUNCTION, 2, 0, 0, 0, Terminator,
+  3,   naclbitc::MODULE_CODE_FUNCTION, 2, 0, 0, 3, Terminator,
   1,   naclbitc::BLK_CODE_ENTER, naclbitc::FUNCTION_BLOCK_ID, 2, Terminator,
   3,     naclbitc::FUNC_CODE_DECLAREBLOCKS, 1, Terminator,
   3,     naclbitc::FUNC_CODE_INST_STORE, 2, 1, getEncAlignPower(0), Terminator,
   3,     naclbitc::FUNC_CODE_INST_RET, 1, Terminator,
   0,   naclbitc::BLK_CODE_EXIT, Terminator,
   0, naclbitc::BLK_CODE_EXIT, Terminator};
 
   const uint64_t ReplaceIndex = 10; // index for FUNC_CODE_INST_STORE
 
   // Show text when alignment is 1.
@@ skipping 66 matching lines @@
   EXPECT_EQ("Error(62:4): Invalid function record: <24 2 1 31>\n",
             Munger.getTestResults());
   EXPECT_FALSE(DumpMunger.runTestForAssembly(ARRAY(Align30)));
   EXPECT_EQ(
       "    store float %p1, float* %p0, align 0;\n"
       "Error(62:4): store: Illegal alignment for float. Expects: 1 or 4\n",
       DumpMunger.getLinesWithSubstring("store"));
 }
 
 } // end of anonymous namespace