tests_lit/reader_tests/globalrelocs.ll - Issue 1387963002: Make sure that all globals are internal, except for "start" functions.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tests_lit/reader_tests/globalrelocs.ll

Issue 1387963002: Make sure that all globals are internal, except for "start" functions. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Fix nit. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« tests_lit/llvm2ice_tests/nacl-mem-intrinsics.ll ('K') | « tests_lit/reader_tests/globalinit.pnacl.ll ('k') | tests_lit/reader_tests/insertextract.ll » ('j') | no next file with comments »

OLD	NEW
1 ; Tests if we handle global variables with relocation initializers.	1 ; Tests if we handle global variables with relocation initializers.

2	2

3 ; RUN: %p2i -i %s --insts \| FileCheck %s	3 ; RUN: %p2i -i %s --insts \| FileCheck %s

4 ; RUN: %l2i -i %s --insts \| %ifl FileCheck %s	4 ; RUN: %l2i -i %s --insts \| %ifl FileCheck %s

5 ; RUN: %lc2i -i %s --insts \| %iflc FileCheck %s	5 ; RUN: %lc2i -i %s --insts \| %iflc FileCheck %s

6 ; RUN: %if --need=allow_disable_ir_gen --command \	6 ; RUN: %if --need=allow_disable_ir_gen --command \

7 ; RUN: %p2i -i %s --args -notranslate -timing -no-ir-gen \	7 ; RUN: %p2i -i %s --args -notranslate -timing -no-ir-gen \

8 ; RUN: \| %if --need=allow_disable_ir_gen --command \	8 ; RUN: \| %if --need=allow_disable_ir_gen --command \

9 ; RUN: FileCheck --check-prefix=NOIR %s	9 ; RUN: FileCheck --check-prefix=NOIR %s

10	10

(...skipping 75 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
86	86

87 @const_ptr_to_func_align = internal constant i32 ptrtoint (void ()* @func to i32 ), align 8	87 @const_ptr_to_func_align = internal constant i32 ptrtoint (void ()* @func to i32 ), align 8

88 ; CHECK-NEXT: @const_ptr_to_func_align = internal constant i32 ptrtoint (void () * @func to i32), align 8	88 ; CHECK-NEXT: @const_ptr_to_func_align = internal constant i32 ptrtoint (void () * @func to i32), align 8

89	89

90 @char = internal constant [1 x i8] c"0"	90 @char = internal constant [1 x i8] c"0"

91 ; CHECK-NEXT: @char = internal constant [1 x i8] c"0"	91 ; CHECK-NEXT: @char = internal constant [1 x i8] c"0"

92	92

93 @short = internal constant [2 x i8] zeroinitializer	93 @short = internal constant [2 x i8] zeroinitializer

94 ; CHECK-NEXT: @short = internal constant [2 x i8] zeroinitializer	94 ; CHECK-NEXT: @short = internal constant [2 x i8] zeroinitializer

95	95

96 define void @func() {	96 define internal void @func() {

97 ret void	97 ret void

98 }	98 }

99	99

100 ; CHECK-NEXT: define void @func() {	100 ; CHECK-NEXT: define internal void @func() {

101	101

102 ; NOIR: Total across all functions	102 ; NOIR: Total across all functions

OLD	NEW