Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 13878015: Avoid C++11 narrowing errors. (Closed)

Created:
7 years, 8 months ago by Raphael Kubo da Costa (rakuco)
Modified:
7 years, 8 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, erikwright+watch_chromium.org, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@speech-dispatcher-version-fix
Visibility:
Public.

Description

Avoid C++11 narrowing errors. C++11 is picker about narrowing inside initializers. Avoid errors related to that by explicitly casting to the appropriate types or changing the types in function declarations where possible. BUG= TEST=Build with gcc and -Wnarrowing. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195114

Patch Set 1 #

Patch Set 2 : Try to make MSVC happy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M base/strings/string_number_conversions_unittest.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M net/spdy/spdy_test_util_spdy3.h View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_test_util_spdy3.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
Raphael Kubo da Costa (rakuco)
7 years, 8 months ago (2013-04-18 13:25:03 UTC) #1
jar (doing other things)
net and base LGTM
7 years, 8 months ago (2013-04-18 16:22:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raphael.kubo.da.costa@intel.com/13878015/1
7 years, 8 months ago (2013-04-18 17:32:52 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-18 17:56:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raphael.kubo.da.costa@intel.com/13878015/1
7 years, 8 months ago (2013-04-18 18:03:24 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-18 18:11:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raphael.kubo.da.costa@intel.com/13878015/1
7 years, 8 months ago (2013-04-18 18:21:00 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-18 18:32:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raphael.kubo.da.costa@intel.com/13878015/25001
7 years, 8 months ago (2013-04-18 18:43:35 UTC) #9
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=30297
7 years, 8 months ago (2013-04-18 22:10:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raphael.kubo.da.costa@intel.com/13878015/25001
7 years, 8 months ago (2013-04-19 07:48:32 UTC) #11
commit-bot: I haz the power
7 years, 8 months ago (2013-04-19 08:59:42 UTC) #12
Message was sent while issue was closed. 
Change committed as 195114

Powered by Google App Engine
This is Rietveld 408576698