chromeos: Return error from DriveResourceMetadata when there is no sufficient disk space

chromeos: Return error from DriveResourceMetadata when there is no sufficient disk space

BUG=232309
TEST=Open Files.app, make the disk full (e.g. by copying big files a lot of times in Download directory), open Google Drive directory, try to create a directory and see the operation failing without crash.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195113

[hidehiko, 2013-04-18 12:45:48]

https://codereview.chromium.org/13878013/diff/2001/chrome/browser/chromeos/dr...
File chrome/browser/chromeos/drive/drive_resource_metadata.cc (right):

https://codereview.chromium.org/13878013/diff/2001/chrome/browser/chromeos/dr...
chrome/browser/chromeos/drive/drive_resource_metadata.cc:49: const int64
kRequiredDiskSpaceInMB = 128;
Could you add comments the background about why 128MB is required?

https://codereview.chromium.org/13878013/diff/2001/chrome/browser/chromeos/dr...
chrome/browser/chromeos/drive/drive_resource_metadata.cc:51:
kRequiredDiskSpaceInMB*(1 << 20);
nit: s/*/ * /

https://codereview.chromium.org/13878013/diff/2001/chrome/browser/chromeos/dr...
chrome/browser/chromeos/drive/drive_resource_metadata.cc:548: if
(!EnoughDiskSpaceIsAvailableForDBOperation(data_directory_path_))
Is it necessary to check disk space for removing operations, too?

[hashimoto, 2013-04-18 13:06:56]

https://chromiumcodereview.appspot.com/13878013/diff/2001/chrome/browser/chro...
File chrome/browser/chromeos/drive/drive_resource_metadata.cc (right):

https://chromiumcodereview.appspot.com/13878013/diff/2001/chrome/browser/chro...
chrome/browser/chromeos/drive/drive_resource_metadata.cc:49: const int64
kRequiredDiskSpaceInMB = 128;
On 2013/04/18 12:45:48, hidehiko wrote:
> Could you add comments the background about why 128MB is required?

Done.

https://chromiumcodereview.appspot.com/13878013/diff/2001/chrome/browser/chro...
chrome/browser/chromeos/drive/drive_resource_metadata.cc:51:
kRequiredDiskSpaceInMB*(1 << 20);
On 2013/04/18 12:45:48, hidehiko wrote:
> nit: s/*/ * /

Done.

https://chromiumcodereview.appspot.com/13878013/diff/2001/chrome/browser/chro...
chrome/browser/chromeos/drive/drive_resource_metadata.cc:548: if
(!EnoughDiskSpaceIsAvailableForDBOperation(data_directory_path_))
On 2013/04/18 12:45:48, hidehiko wrote:
> Is it necessary to check disk space for removing operations, too?

Yes, sometimes it results in adding an entry to the DB and might result in
compaction. (see http://leveldb.googlecode.com/svn/trunk/doc/impl.html for
details.)

[hidehiko, 2013-04-18 13:09:45]

lgtm

[commit-bot: I haz the power, 2013-04-18 16:34:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hashimoto@chromium.org/13878013/8001

[commit-bot: I haz the power, 2013-04-18 19:36:41]

Retried try job too often on win7_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[commit-bot: I haz the power, 2013-04-19 02:25:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hashimoto@chromium.org/13878013/8001

[commit-bot: I haz the power, 2013-04-19 08:59:18]

Change committed as 195113