Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3397)

Unified Diff: build/android/gyp/apk_install.py

Issue 13877025: [Android] With gyp_managed_install no device is only a warning (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/android/gyp/create_device_library_links.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/gyp/apk_install.py
diff --git a/build/android/gyp/apk_install.py b/build/android/gyp/apk_install.py
index 714be081ca14c1084284e57c66336dcd5f7e842a..9431b29df0bbad750423bdb89bb0ada6fd3bb07f 100755
--- a/build/android/gyp/apk_install.py
+++ b/build/android/gyp/apk_install.py
@@ -56,6 +56,11 @@ def RecordInstallMetadata(apk_package, metadata_path):
def main(argv):
+ if not build_utils.IsDeviceReady():
+ build_utils.PrintBigWarning(
+ 'Zero (or multiple) devices attached. Skipping APK install.')
+ return
+
parser = optparse.OptionParser()
parser.add_option('--android-sdk-tools',
help='Path to Android SDK tools.')
« no previous file with comments | « no previous file | build/android/gyp/create_device_library_links.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698