Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 13877025: [Android] With gyp_managed_install no device is only a warning (Closed)

Created:
7 years, 8 months ago by cjhopman
Modified:
7 years, 7 months ago
Reviewers:
newt (away)
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, klundberg+watch_chromium.org, ilevy+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

[Android] With gyp_managed_install no device is only a warning Before running any action that interacts with the device, check that one is actually attached. If not, print a big warning and skip the action. BUG=235521 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199263

Patch Set 1 : #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -1 line) Patch
M build/android/gyp/apk_install.py View 1 1 chunk +5 lines, -0 lines 0 comments Download
M build/android/gyp/create_device_library_links.py View 1 1 chunk +5 lines, -0 lines 0 comments Download
M build/android/gyp/push_libraries.py View 1 1 chunk +5 lines, -0 lines 0 comments Download
M build/android/gyp/util/build_utils.py View 2 chunks +17 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
cjhopman
7 years, 8 months ago (2013-04-27 00:43:46 UTC) #1
newt (away)
lgtm with one question https://codereview.chromium.org/13877025/diff/5001/build/android/gyp/util/build_utils.py File build/android/gyp/util/build_utils.py (right): https://codereview.chromium.org/13877025/diff/5001/build/android/gyp/util/build_utils.py#newcode135 build/android/gyp/util/build_utils.py:135: device_state = CheckCallDie(['adb', 'get-state'], suppress_output=True) ...
7 years, 7 months ago (2013-04-29 21:23:56 UTC) #2
cjhopman
https://codereview.chromium.org/13877025/diff/5001/build/android/gyp/util/build_utils.py File build/android/gyp/util/build_utils.py (right): https://codereview.chromium.org/13877025/diff/5001/build/android/gyp/util/build_utils.py#newcode135 build/android/gyp/util/build_utils.py:135: device_state = CheckCallDie(['adb', 'get-state'], suppress_output=True) On 2013/04/29 21:23:57, newt ...
7 years, 7 months ago (2013-04-30 00:32:15 UTC) #3
newt (away)
https://codereview.chromium.org/13877025/diff/5001/build/android/gyp/push_libraries.py File build/android/gyp/push_libraries.py (right): https://codereview.chromium.org/13877025/diff/5001/build/android/gyp/push_libraries.py#newcode53 build/android/gyp/push_libraries.py:53: 'No device attached. Skipping native library push.') how about ...
7 years, 7 months ago (2013-04-30 00:34:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/13877025/13001
7 years, 7 months ago (2013-05-09 20:13:09 UTC) #5
commit-bot: I haz the power
7 years, 7 months ago (2013-05-09 20:24:26 UTC) #6
Message was sent while issue was closed.
Change committed as 199263

Powered by Google App Engine
This is Rietveld 408576698