Issue 13876003: chromeos: Stop removing the entry from the storage of DriveResourceMetadata when unnecessary

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13876003: chromeos: Stop removing the entry from the storage of DriveResourceMetadata when unnecessary (Closed)

Created:
7 years, 8 months ago by hashimoto

Modified:
7 years, 8 months ago

Reviewers:
hidehiko

CC:
chromium-reviews, tfarina, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

chromeos: Stop removing the entry from the storage of DriveResourceMetadata when unnecessary RemoveDirectoryChild is the only place where the entry must be removed. For all other RemoveDirectoryChild users, just destroying parent-child relationship is enough. BUG=None TEST=unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192994

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	chrome/browser/chromeos/drive/drive_resource_metadata.cc	View		2 chunks	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/13876003/1

7 years, 8 months ago (2013-04-09 01:34:52 UTC) #3

Message was sent while issue was closed.

Change committed as 192994

Expand Messages | Collapse Messages