Suppress glib/gthread leaks in component build.

Suppress glib/gthread leaks in component build.

NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195011

[Ryan Hamilton, 2013-04-18 17:45:49]

I'm not sure if this is the right suppression to land, but it works for me, and
covers the 9 failures I see...

[Reid Kleckner, 2013-04-18 18:06:12]

https://codereview.chromium.org/13874012/diff/1/tools/valgrind/memcheck/suppr...
File tools/valgrind/memcheck/suppressions.txt (right):

https://codereview.chromium.org/13874012/diff/1/tools/valgrind/memcheck/suppr...
tools/valgrind/memcheck/suppressions.txt:7032: glib/gthread malloc leak in
component build
These kinds of leaks from system components that we don't control should go at
the end of section 1.  Search for "# 2." and put it before that.

https://codereview.chromium.org/13874012/diff/1/tools/valgrind/memcheck/suppr...
tools/valgrind/memcheck/suppressions.txt:7035: ...
This file uses 3 space indents.  Yes, I know it's weird.  I don't know who
started it.

https://codereview.chromium.org/13874012/diff/1/tools/valgrind/memcheck/suppr...
tools/valgrind/memcheck/suppressions.txt:7039: glib/gthread calloc leak in
component build
ditto

https://codereview.chromium.org/13874012/diff/1/tools/valgrind/memcheck/suppr...
tools/valgrind/memcheck/suppressions.txt:7043: fun:g_thread_proxy
Are you reasonably sure this happens once per thread creation?

[Ryan Hamilton, 2013-04-18 18:16:53]

https://codereview.chromium.org/13874012/diff/1/tools/valgrind/memcheck/suppr...
File tools/valgrind/memcheck/suppressions.txt (right):

https://codereview.chromium.org/13874012/diff/1/tools/valgrind/memcheck/suppr...
tools/valgrind/memcheck/suppressions.txt:7032: glib/gthread malloc leak in
component build
On 2013/04/18 18:06:12, Reid Kleckner wrote:
> These kinds of leaks from system components that we don't control should go at
> the end of section 1.  Search for "# 2." and put it before that.

Done.

https://codereview.chromium.org/13874012/diff/1/tools/valgrind/memcheck/suppr...
tools/valgrind/memcheck/suppressions.txt:7035: ...
On 2013/04/18 18:06:12, Reid Kleckner wrote:
> This file uses 3 space indents.  Yes, I know it's weird.  I don't know who
> started it.

Woah!  How did those tabs get in there.  Sorry!  (Since this a .txt file, I'll
bet my emacs indenting config is confused).  Done.

https://codereview.chromium.org/13874012/diff/1/tools/valgrind/memcheck/suppr...
tools/valgrind/memcheck/suppressions.txt:7039: glib/gthread calloc leak in
component build
On 2013/04/18 18:06:12, Reid Kleckner wrote:
> ditto

Done.

https://codereview.chromium.org/13874012/diff/1/tools/valgrind/memcheck/suppr...
tools/valgrind/memcheck/suppressions.txt:7043: fun:g_thread_proxy
On 2013/04/18 18:06:12, Reid Kleckner wrote:
> Are you reasonably sure this happens once per thread creation?

I have no idea whatsoever :(  All I know is that these errors show up ever time
I run net_unittests under valgrind when build via the component build, but do
not happen in the regular build.  Since they appear to originate in
glib/gthread, I think they're not "us", but I really don't know anything beyond
that...

[Reid Kleckner, 2013-04-18 18:26:55]

LGTM

If you go through the CQ, feel free to set NOTRY=true since this is a non-source
change that only affects the valgrind bots, which aren't part of the default CQ
bots.

[Ryan Hamilton, 2013-04-18 18:29:42]

On 2013/04/18 18:26:55, Reid Kleckner wrote:
> LGTM
> 
> If you go through the CQ, feel free to set NOTRY=true since this is a
non-source
> change that only affects the valgrind bots, which aren't part of the default
CQ
> bots.

Great, thanks!

[commit-bot: I haz the power, 2013-04-18 21:35:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rch@chromium.org/13874012/5001

[commit-bot: I haz the power, 2013-04-18 21:35:52]

Presubmit check for 13874012-5001 failed and returned exit status 1.

INFO:root:Found 1 file(s).

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Traceback (most recent call last):
  File "/b/commit-queue/verification/presubmit_shim.py", line 33, in <module>
    sys.exit(presubmit_support.Main(argv))
  File "/b/depot_tools/presubmit_support.py", line 1305, in Main
    rietveld_obj)
  File "/b/depot_tools/presubmit_support.py", line 1129, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "/b/depot_tools/presubmit_support.py", line 1046, in ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 865, in CheckChangeOnCommit
  File "<string>", line 710, in _CommonChecks
  File "<string>", line 633, in _CheckForVersionControlConflicts
  File "<string>", line 623, in _CheckForVersionControlConflictsInFile
  File "/b/depot_tools/presubmit_support.py", line 549, in ChangedContents
    for line in self.GenerateScmDiff().splitlines():
  File "/b/depot_tools/presubmit_support.py", line 619, in GenerateScmDiff
    [self.LocalPath()], self._local_root, False, None)
  File "/b/depot_tools/scm.py", line 913, in GenerateDiff
    full_move, revision))
  File "/b/depot_tools/scm.py", line 837, in _DiffItemInternal
    data = SVN.Capture(command, cwd)
  File "/b/depot_tools/scm.py", line 479, in Capture
    ['svn'] + args, stderr=subprocess2.PIPE, cwd=cwd, **kwargs)
  File "/b/depot_tools/subprocess2.py", line 449, in check_output
    return check_call_out(args, stdout=PIPE, **kwargs)[0]
  File "/b/depot_tools/subprocess2.py", line 412, in check_call_out
    returncode, args, kwargs.get('cwd'), out[0], out[1])
subprocess2.CalledProcessError: Command svn diff --internal-diff
tools/valgrind/memcheck/suppressions.txt returned non-zero exit status 1 in
/b/commit-queue/workdir/chromium
svn: invalid option: --internal-diff
Type 'svn help' for usage.

[commit-bot: I haz the power, 2013-04-18 21:40:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rch@chromium.org/13874012/5001

[commit-bot: I haz the power, 2013-04-18 21:40:48]

Presubmit check for 13874012-5001 failed and returned exit status 1.

INFO:root:Found 1 file(s).

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Traceback (most recent call last):
  File "/b/commit-queue/verification/presubmit_shim.py", line 33, in <module>
    sys.exit(presubmit_support.Main(argv))
  File "/b/depot_tools/presubmit_support.py", line 1305, in Main
    rietveld_obj)
  File "/b/depot_tools/presubmit_support.py", line 1129, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "/b/depot_tools/presubmit_support.py", line 1046, in ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 865, in CheckChangeOnCommit
  File "<string>", line 710, in _CommonChecks
  File "<string>", line 633, in _CheckForVersionControlConflicts
  File "<string>", line 623, in _CheckForVersionControlConflictsInFile
  File "/b/depot_tools/presubmit_support.py", line 549, in ChangedContents
    for line in self.GenerateScmDiff().splitlines():
  File "/b/depot_tools/presubmit_support.py", line 619, in GenerateScmDiff
    [self.LocalPath()], self._local_root, False, None)
  File "/b/depot_tools/scm.py", line 913, in GenerateDiff
    full_move, revision))
  File "/b/depot_tools/scm.py", line 837, in _DiffItemInternal
    data = SVN.Capture(command, cwd)
  File "/b/depot_tools/scm.py", line 479, in Capture
    ['svn'] + args, stderr=subprocess2.PIPE, cwd=cwd, **kwargs)
  File "/b/depot_tools/subprocess2.py", line 449, in check_output
    return check_call_out(args, stdout=PIPE, **kwargs)[0]
  File "/b/depot_tools/subprocess2.py", line 412, in check_call_out
    returncode, args, kwargs.get('cwd'), out[0], out[1])
subprocess2.CalledProcessError: Command svn diff --internal-diff
tools/valgrind/memcheck/suppressions.txt returned non-zero exit status 1 in
/b/commit-queue/workdir/chromium
svn: invalid option: --internal-diff
Type 'svn help' for usage.

[commit-bot: I haz the power, 2013-04-18 21:50:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rch@chromium.org/13874012/14001

[commit-bot: I haz the power, 2013-04-18 21:51:00]

Change committed as 195011