Issue 13874011: Start registering for the kEulaAccepted for mobile

Issue 13874011: Start registering for the kEulaAccepted for mobile (Closed)

Created:
7 years, 8 months ago by Yusuf

Modified:
7 years, 8 months ago

Reviewers:
Denis Kuznetsov (DE-MUC), Nikita (slow), Alexei Svitkine (slow), Nico

CC:
chromium-reviews, sail+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, SteveT, sky

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Start registering for the kEulaAccepted for mobile This flag will be used by Android, iOS and CrOS. So removing the CrOS only registration and adding it to profile. BUG=227071 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195283

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added pref in browserProcessImpl #

Patch Set 3 : Moved the removal from wizard_controller to startup_utils #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	chrome/browser/browser_process_impl.cc	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
	M	chrome/browser/chromeos/login/startup_utils.cc	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 11 (0 generated)

Expand Messages | Collapse Messages

Alexei Svitkine (slow)

https://codereview.chromium.org/13874011/diff/1/chrome/browser/profiles/profile.cc File chrome/browser/profiles/profile.cc (right): https://codereview.chromium.org/13874011/diff/1/chrome/browser/profiles/profile.cc#newcode122 chrome/browser/profiles/profile.cc:122: registry->RegisterBooleanPref(prefs::kEulaAccepted, I believe this is the wrong place to ...

7 years, 8 months ago (2013-04-18 17:38:31 UTC) #2

Alexei Svitkine (slow)

LGTM. +nkostylev for chromeos/ OWNERS +sky for chrome/ OWNERS

7 years, 8 months ago (2013-04-18 18:56:03 UTC) #4

Alexei Svitkine (slow)

Err, sky is still OOO. +thakis for chrome/ OWNERS

7 years, 8 months ago (2013-04-18 19:16:37 UTC) #5

Denis Kuznetsov (DE-MUC)

It can clash with https://codereview.chromium.org/14362031/ - code is moved from WizardController to separate StartupUtils class.

7 years, 8 months ago (2013-04-19 14:50:41 UTC) #8

rohitrao (ping after 24h)

On 2013/04/19 14:50:41, Denis Kuznetsov wrote: > It can clash with https://codereview.chromium.org/14362031/ - code is ...

7 years, 8 months ago (2013-04-19 17:15:42 UTC) #9

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusufo@chromium.org/13874011/11002

7 years, 8 months ago (2013-04-19 17:20:41 UTC) #10

Message was sent while issue was closed.

Change committed as 195283

Expand Messages | Collapse Messages