Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Unified Diff: sdk/lib/html/html_common/filtered_element_list.dart

Issue 13872007: Refactor removeRange. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Rebuild dom. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/html/html_common/filtered_element_list.dart
diff --git a/sdk/lib/html/html_common/filtered_element_list.dart b/sdk/lib/html/html_common/filtered_element_list.dart
index afc6a073a52aad8865642f394c46a70035f495b2..217345395cf0997b44ccc4639ac0aa5d08abce12 100644
--- a/sdk/lib/html/html_common/filtered_element_list.dart
+++ b/sdk/lib/html/html_common/filtered_element_list.dart
@@ -46,7 +46,7 @@ class FilteredElementList extends ListBase<Element> {
throw new ArgumentError("Invalid list length");
}
- removeRange(newLength, len - newLength);
+ removeRange(newLength, len);
}
String join([String separator = ""]) => _filtered.join(separator);
@@ -75,8 +75,8 @@ class FilteredElementList extends ListBase<Element> {
throw new UnimplementedError();
}
- void removeRange(int start, int rangeLength) {
- _filtered.sublist(start, start + rangeLength).forEach((el) => el.remove());
+ void removeRange(int start, int end) {
+ _filtered.sublist(start, end).forEach((el) => el.remove());
}
void insertRange(int start, int rangeLength, [initialValue = null]) {

Powered by Google App Engine
This is Rietveld 408576698