Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5391)

Unified Diff: sdk/lib/core/list.dart

Issue 13872007: Refactor removeRange. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Rebuild dom. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/core/list.dart
diff --git a/sdk/lib/core/list.dart b/sdk/lib/core/list.dart
index 2c1d7422060f7f8c37ffb18683353d922956d049..423e8997f2ba849e0b9bd3f38030541c7de50bb8 100644
--- a/sdk/lib/core/list.dart
+++ b/sdk/lib/core/list.dart
@@ -242,7 +242,7 @@ abstract class List<E> implements Collection<E> {
/**
* Copies the elements of [from], starting
- * at [startFrom], into the range [start] - [end] of `this`.
+ * at [startFrom], into the range [start] - [end] (excluding) of `this`.
*
* If [start] equals [end], this method does not do anything.
*
@@ -255,15 +255,12 @@ abstract class List<E> implements Collection<E> {
void setRange(int start, int end, List<E> from, [int startFrom]);
/**
- * Removes [length] elements from the list, beginning at [start].
- * Throws an [UnsupportedError] if the list is
- * not extendable.
- * If [length] is 0, this method does not do anything.
- * Throws an [ArgumentError] if [length] is negative.
- * Throws an [RangeError] if [start] or
- * [:start + length: - 1] are out of range.
+ * Removes the elements in the range [start]..[end] (excluding).
+ *
+ * It is an error if [start]..[end] is not a valid range pointing into the
+ * `this`.
*/
- void removeRange(int start, int length);
+ void removeRange(int start, int end);
/**
* Inserts a new range into the list, starting from [start] to

Powered by Google App Engine
This is Rietveld 408576698