Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Unified Diff: sdk/lib/html/html_common/filtered_element_list.dart

Issue 13872007: Refactor removeRange. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Update status files and rebuild dom (unrelated CL). Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/html/dartium/html_dartium.dart ('k') | sdk/lib/io/http_headers.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/html/html_common/filtered_element_list.dart
diff --git a/sdk/lib/html/html_common/filtered_element_list.dart b/sdk/lib/html/html_common/filtered_element_list.dart
index 33bf357a0d1f3040d8e75ac0a5717b48f082244c..654d0b7fb249cd5e25d0045f6a6e05f6be74f4b6 100644
--- a/sdk/lib/html/html_common/filtered_element_list.dart
+++ b/sdk/lib/html/html_common/filtered_element_list.dart
@@ -46,7 +46,7 @@ class FilteredElementList extends ListBase<Element> {
throw new ArgumentError("Invalid list length");
}
- removeRange(newLength, len - newLength);
+ removeRange(newLength, len);
}
String join([String separator = ""]) => _filtered.join(separator);
@@ -76,8 +76,8 @@ class FilteredElementList extends ListBase<Element> {
throw new UnimplementedError();
}
- void removeRange(int start, int rangeLength) {
- _filtered.sublist(start, start + rangeLength).forEach((el) => el.remove());
+ void removeRange(int start, int end) {
+ _filtered.sublist(start, end).forEach((el) => el.remove());
}
void insertRange(int start, int rangeLength, [initialValue = null]) {
« no previous file with comments | « sdk/lib/html/dartium/html_dartium.dart ('k') | sdk/lib/io/http_headers.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698