Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Side by Side Diff: third_party/WebKit/Source/core/css/resolver/ElementStyleResources.h

Issue 1387113002: Change StyleResolverState.styleImage() to take a const CSSValue& (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added TODOs to replace the members with const members Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved. 3 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
4 * Copyright (C) 2013 Google Inc. All rights reserved. 4 * Copyright (C) 2013 Google Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 using PendingSVGDocumentMap = WillBeHeapHashMap<RawPtrWillBeMember<FilterOperati on>, RefPtrWillBeMember<CSSSVGDocumentValue>>; 45 using PendingSVGDocumentMap = WillBeHeapHashMap<RawPtrWillBeMember<FilterOperati on>, RefPtrWillBeMember<CSSSVGDocumentValue>>;
46 46
47 // Holds information about resources, requested by stylesheets. 47 // Holds information about resources, requested by stylesheets.
48 // Lifetime: per-element style resolve. 48 // Lifetime: per-element style resolve.
49 class ElementStyleResources { 49 class ElementStyleResources {
50 STACK_ALLOCATED(); 50 STACK_ALLOCATED();
51 WTF_MAKE_NONCOPYABLE(ElementStyleResources); 51 WTF_MAKE_NONCOPYABLE(ElementStyleResources);
52 public: 52 public:
53 ElementStyleResources(); 53 ElementStyleResources();
54 54
55 PassRefPtrWillBeRawPtr<StyleImage> styleImage(Document&, CSSPropertyID, CSSV alue*); 55 PassRefPtrWillBeRawPtr<StyleImage> styleImage(Document&, CSSPropertyID, cons t CSSValue&);
56 56
57 PassRefPtrWillBeRawPtr<StyleImage> generatedOrPendingFromValue(CSSPropertyID , CSSImageGeneratorValue*); 57 PassRefPtrWillBeRawPtr<StyleImage> generatedOrPendingFromValue(CSSPropertyID , const CSSImageGeneratorValue&);
58 PassRefPtrWillBeRawPtr<StyleImage> cachedOrPendingFromValue(Document&, CSSPr opertyID, CSSImageValue*); 58 PassRefPtrWillBeRawPtr<StyleImage> cachedOrPendingFromValue(Document&, CSSPr opertyID, const CSSImageValue&);
59 PassRefPtrWillBeRawPtr<StyleImage> setOrPendingFromValue(CSSPropertyID, CSSI mageSetValue*); 59 PassRefPtrWillBeRawPtr<StyleImage> setOrPendingFromValue(CSSPropertyID, cons t CSSImageSetValue&);
60 PassRefPtrWillBeRawPtr<StyleImage> cursorOrPendingFromValue(CSSPropertyID, C SSCursorImageValue*); 60 PassRefPtrWillBeRawPtr<StyleImage> cursorOrPendingFromValue(CSSPropertyID, c onst CSSCursorImageValue&);
61 61
62 const PendingImagePropertySet& pendingImageProperties() const { return m_pen dingImageProperties; } 62 const PendingImagePropertySet& pendingImageProperties() const { return m_pen dingImageProperties; }
63 const PendingSVGDocumentMap& pendingSVGDocuments() const { return m_pendingS VGDocuments; } 63 const PendingSVGDocumentMap& pendingSVGDocuments() const { return m_pendingS VGDocuments; }
64 64
65 void clearPendingImageProperties(); 65 void clearPendingImageProperties();
66 void clearPendingSVGDocuments(); 66 void clearPendingSVGDocuments();
67 67
68 float deviceScaleFactor() const { return m_deviceScaleFactor; } 68 float deviceScaleFactor() const { return m_deviceScaleFactor; }
69 void setDeviceScaleFactor(float deviceScaleFactor) { m_deviceScaleFactor = d eviceScaleFactor; } 69 void setDeviceScaleFactor(float deviceScaleFactor) { m_deviceScaleFactor = d eviceScaleFactor; }
70 70
71 void addPendingSVGDocument(FilterOperation*, CSSSVGDocumentValue*); 71 void addPendingSVGDocument(FilterOperation*, CSSSVGDocumentValue*);
72 72
73 private: 73 private:
74 PendingImagePropertySet m_pendingImageProperties; 74 PendingImagePropertySet m_pendingImageProperties;
75 PendingSVGDocumentMap m_pendingSVGDocuments; 75 PendingSVGDocumentMap m_pendingSVGDocuments;
76 float m_deviceScaleFactor; 76 float m_deviceScaleFactor;
77 }; 77 };
78 78
79 } // namespace blink 79 } // namespace blink
80 80
81 #endif // ElementStyleResources_h 81 #endif // ElementStyleResources_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698