Issue 13871009: Move signin_manager_fake.* to fake_signin_manager.*

Issue 13871009: Move signin_manager_fake.* to fake_signin_manager.* (Closed)

Created:
7 years, 8 months ago by Andrew T Wilson (Slow)

Modified:
7 years, 8 months ago

Reviewers:
Roger Tawa OOO till Jul 10th

CC:
chromium-reviews, sail+watch_chromium.org, Raghu Simha, haitaol1, akalin, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move signin_manager_fake.* to fake_signin_manager.* This fixes a coding convention violation (since signin_manager_fake.h actually defined FakeSigninManager) and also matches what the rest of Chrome does (there is only one other instance of xxxxx_fake.cc, but many instances of fake_xxxxx.cc). BUG=none TBR=sky@chromium.org, tim@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194985

Patch Set 1 #

Patch Set 2 : Merge to TOT #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -143 lines)			Patch
M	chrome/browser/policy/cloud/user_cloud_policy_store_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	chrome/browser/signin/fake_signin_manager.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
A +	chrome/browser/signin/fake_signin_manager.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/signin/signin_global_error_unittest.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/browser/signin/signin_manager_fake.h	View		1 chunk	+0 lines, -49 lines	0 comments	Download
D	chrome/browser/signin/signin_manager_fake.cc	View		1 chunk	+0 lines, -78 lines	0 comments	Download
M	chrome/browser/signin/signin_tracker_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/profile_sync_service_startup_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/sync_ui_util_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/browser_window_controller_unittest.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/sync/one_click_signin_helper_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/sync_setup_handler_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/test/base/chrome_render_view_host_test_harness.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Andrew T Wilson (Slow)

PTAL. This is just a simple file rename that's been bugging me for several months ...

7 years, 8 months ago (2013-04-16 12:10:15 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/atwilson@chromium.org/13871009/11001

7 years, 8 months ago (2013-04-18 13:06:20 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=136268

7 years, 8 months ago (2013-04-18 16:33:04 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/atwilson@chromium.org/13871009/11001

7 years, 8 months ago (2013-04-18 18:36:09 UTC) #5

Message was sent while issue was closed.

Change committed as 194985

Expand Messages | Collapse Messages