Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2926)

Unified Diff: chrome/test/chromedriver/element_util.cc

Issue 13870016: [chromedriver] Fix nested frame issue for command getElementLocationOnceScrolledIntoView. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Just rebase. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/element_util.h ('k') | chrome/test/chromedriver/test_expectations » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/element_util.cc
diff --git a/chrome/test/chromedriver/element_util.cc b/chrome/test/chromedriver/element_util.cc
index ca14b20eee4cae1c3b1e5b901423a1b09feee3ad..9fc2315841fae0d9d1206a87143c9fb9e9088e01 100644
--- a/chrome/test/chromedriver/element_util.cc
+++ b/chrome/test/chromedriver/element_util.cc
@@ -34,13 +34,6 @@ bool ParseFromValue(base::Value* value, WebPoint* point) {
return true;
}
-base::Value* CreateValueFrom(const WebPoint& point) {
- base::DictionaryValue* dict = new base::DictionaryValue();
- dict->SetInteger("x", point.x);
- dict->SetInteger("y", point.y);
- return dict;
-}
-
bool ParseFromValue(base::Value* value, WebSize* size) {
base::DictionaryValue* dict_value;
if (!value->GetAsDictionary(&dict_value))
@@ -219,6 +212,13 @@ base::DictionaryValue* CreateElement(const std::string& element_id) {
return element;
}
+base::Value* CreateValueFrom(const WebPoint& point) {
+ base::DictionaryValue* dict = new base::DictionaryValue();
+ dict->SetInteger("x", point.x);
+ dict->SetInteger("y", point.y);
+ return dict;
+}
+
Status FindElement(
int interval_ms,
bool only_one,
« no previous file with comments | « chrome/test/chromedriver/element_util.h ('k') | chrome/test/chromedriver/test_expectations » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698