Issue 13870016: [chromedriver] Fix nested frame issue for command getElementLocationOnceScrolledIntoView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13870016: [chromedriver] Fix nested frame issue for command getElementLocationOnceScrolledIntoView. (Closed)

Created:
7 years, 8 months ago by chrisgao (Use stgao instead)

Modified:
7 years, 8 months ago

Reviewers:
kkania

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[chromedriver] Fix nested frame issue for command getElementLocationOnceScrolledIntoView. Also enable two passed java tests. BUG= NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195036

Patch Set 1 #

Patch Set 2 : Just rebase. #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -16 lines)			Patch
M	chrome/test/chromedriver/element_commands.cc	View	1	1 chunk	+7 lines, -7 lines	0 comments	Download
M	chrome/test/chromedriver/element_util.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/test/chromedriver/element_util.cc	View	1	2 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/test/chromedriver/test_expectations	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrisgao@chromium.org/13870016/4001

7 years, 8 months ago (2013-04-18 18:54:51 UTC) #4

commit-bot: I haz the power

Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=30319

7 years, 8 months ago (2013-04-18 22:49:48 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrisgao@chromium.org/13870016/4001

7 years, 8 months ago (2013-04-19 00:59:00 UTC) #6

Message was sent while issue was closed.

Change committed as 195036

Expand Messages | Collapse Messages