Issue 13870013: Pass texture target to CreateResourceFromExternalTexture

Issue 13870013: Pass texture target to CreateResourceFromExternalTexture (Closed)

Created:
7 years, 8 months ago by boliu

Modified:
7 years, 8 months ago

Reviewers:
danakj, no sievers, piman

CC:
chromium-reviews, cc-bugs_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Pass texture target to CreateResourceFromExternalTexture Instead of hardcoding GL_TEXTURE_2D BUG=230300 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194770

Patch Set 2 : GL_TEXTURE_RECTANGLE_ARB in io surface layer #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -9 lines)			Patch
M	cc/layers/io_surface_layer_impl.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	cc/layers/texture_layer_impl.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	cc/resources/resource_provider.h	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	cc/resources/resource_provider.cc	View		1 chunk	+9 lines, -7 lines	0 comments	Download
M	cc/resources/video_resource_updater.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

danakj

https://codereview.chromium.org/13870013/diff/1/cc/layers/io_surface_layer_impl.cc File cc/layers/io_surface_layer_impl.cc (right): https://codereview.chromium.org/13870013/diff/1/cc/layers/io_surface_layer_impl.cc#newcode80 cc/layers/io_surface_layer_impl.cc:80: GL_TEXTURE_2D, Should this be GL_TEXTURE_RECTANGLE_ARB? Other IO surface stuff ...

7 years, 8 months ago (2013-04-17 19:57:49 UTC) #2

boliu

https://codereview.chromium.org/13870013/diff/1/cc/layers/io_surface_layer_impl.cc File cc/layers/io_surface_layer_impl.cc (right): https://codereview.chromium.org/13870013/diff/1/cc/layers/io_surface_layer_impl.cc#newcode80 cc/layers/io_surface_layer_impl.cc:80: GL_TEXTURE_2D, On 2013/04/17 19:57:49, danakj wrote: > Should this ...

7 years, 8 months ago (2013-04-17 20:00:39 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boliu@chromium.org/13870013/3001

7 years, 8 months ago (2013-04-18 01:05:57 UTC) #5

Message was sent while issue was closed.

Change committed as 194770

Expand Messages | Collapse Messages