Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 13867007: Tab audio indicator: Use animation container on Mac (Closed)

Created:
7 years, 8 months ago by sail
Modified:
7 years, 8 months ago
Reviewers:
Nico
CC:
chromium-reviews, sail+watch_chromium.org
Visibility:
Public.

Description

Tab audio indicator: Use animation container on Mac When showning an audio indicator on multiple tabs, the CPU usage on my machine is: 1 tab: 1.5% 2 tab: 2.5% 3 tab: 3.2% This CL uses a common animation container for all tabs in a window. This changes the CPU usage to: 1 tab: 1.5% 2 tab: 1.5% 3 tab: 1.5% BUG=3541 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195059

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -31 lines) Patch
M chrome/browser/ui/cocoa/tabs/tab_audio_indicator_view_mac.h View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_audio_indicator_view_mac.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_projecting_image_view.h View 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_projecting_image_view.mm View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_projecting_image_view_unittest.mm View 1 chunk +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.h View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm View 5 chunks +13 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/throbbing_image_view.h View 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/throbbing_image_view.mm View 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/throbbing_image_view_unittest.mm View 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
sail
7 years, 8 months ago (2013-04-14 18:21:37 UTC) #1
sail
ping!
7 years, 8 months ago (2013-04-16 20:45:17 UTC) #2
Nico
lgtm! Now, what if one keeps youtube in a separate window?
7 years, 8 months ago (2013-04-16 23:23:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/13867007/1
7 years, 8 months ago (2013-04-18 00:09:49 UTC) #4
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 8 months ago (2013-04-18 00:12:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/13867007/1
7 years, 8 months ago (2013-04-18 20:03:51 UTC) #6
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=30374
7 years, 8 months ago (2013-04-19 00:02:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/13867007/1
7 years, 8 months ago (2013-04-19 00:43:54 UTC) #8
commit-bot: I haz the power
7 years, 8 months ago (2013-04-19 03:07:42 UTC) #9
Message was sent while issue was closed.
Change committed as 195059

Powered by Google App Engine
This is Rietveld 408576698