Issue 13865008: Fix WebViewInteractiveTest.NewWindow

Issue 13865008: Fix WebViewInteractiveTest.NewWindow (Closed)

Created:
7 years, 8 months ago by Fady Samuel

Modified:
7 years, 6 months ago

Reviewers:
lazyboy

CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Fix WebViewInteractiveTest.NewWindow Allowing for NULL damage buffers in low memory situations. Ran 200 times on bots. BUG=222618 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204051

Patch Set 1 #

Patch Set 2 : Removed hack to test 100 times on trybot #

Patch Set 3 : Move to web_view_interactive_browsertests.cc #

Patch Set 4 : Another try #

Patch Set 5 : Test new window #

Patch Set 6 : Updated #

Total comments: 1

Patch Set 7 : Got rid of old comment #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	chrome/browser/extensions/web_view_interactive_browsertest.cc	View	1 2 3 4 5 6	1 chunk	+1 line, -2 lines	0 comments	Download
	M	content/browser/browser_plugin/browser_plugin_guest.cc	View	1 2 3 4 5	2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Fady Samuel

Note to self: This probably needs to be an inteactive UI test.

7 years, 8 months ago (2013-04-18 23:22:08 UTC) #1

lazyboy

lgtm https://codereview.chromium.org/13865008/diff/35009/chrome/browser/extensions/web_view_interactive_browsertest.cc File chrome/browser/extensions/web_view_interactive_browsertest.cc (right): https://codereview.chromium.org/13865008/diff/35009/chrome/browser/extensions/web_view_interactive_browsertest.cc#newcode385 chrome/browser/extensions/web_view_interactive_browsertest.cc:385: // Disabled due to timeouts/crashing on several platforms. ...

7 years, 6 months ago (2013-06-04 15:51:43 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/13865008/42002

7 years, 6 months ago (2013-06-04 15:54:53 UTC) #5

Message was sent while issue was closed.

Change committed as 204051

Expand Messages | Collapse Messages