Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Unified Diff: third_party/WebKit/Source/core/style/StylePendingImage.h

Issue 1386413002: Added TODOs to StyleImage::create() to take PassRefPtrWillBeRawPtr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@make_styleresolverstate_styleImage_take_a_const_reference
Patch Set: Added comments to const_cast calls Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/style/StyleGeneratedImage.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/style/StylePendingImage.h
diff --git a/third_party/WebKit/Source/core/style/StylePendingImage.h b/third_party/WebKit/Source/core/style/StylePendingImage.h
index 458a732a8dccdd8d1fb69d2fe425158bcb5bf7b4..fa39c80970e7a831aa00158d3f931952c2b2c483 100644
--- a/third_party/WebKit/Source/core/style/StylePendingImage.h
+++ b/third_party/WebKit/Source/core/style/StylePendingImage.h
@@ -41,7 +41,8 @@ namespace blink {
class StylePendingImage final : public StyleImage {
public:
- static PassRefPtrWillBeRawPtr<StylePendingImage> create(const CSSValue& value)
+ // TODO(sashab): Make this take a PassRefPtrWillBeRawPtr<const CSSValue>.
+ static PassRefPtrWillBeRawPtr<StylePendingImage> create(PassRefPtrWillBeRawPtr<CSSValue> value)
{
return adoptRefWillBeNoop(new StylePendingImage(value));
}
@@ -83,8 +84,8 @@ public:
}
private:
- explicit StylePendingImage(const CSSValue& value)
- : m_value(const_cast<CSSValue*>(&value))
+ explicit StylePendingImage(PassRefPtrWillBeRawPtr<CSSValue> value)
+ : m_value(value)
{
m_isPendingImage = true;
}
« no previous file with comments | « third_party/WebKit/Source/core/style/StyleGeneratedImage.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698