Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Side by Side Diff: third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp

Issue 1386413002: Added TODOs to StyleImage::create() to take PassRefPtrWillBeRawPtr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@make_styleresolverstate_styleImage_take_a_const_reference
Patch Set: Added comments to const_cast calls Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
4 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com) 4 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
5 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com) 5 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved. 6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
7 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 7 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
8 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org> 8 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
9 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 9 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
10 * Copyright (c) 2011, Code Aurora Forum. All rights reserved. 10 * Copyright (c) 2011, Code Aurora Forum. All rights reserved.
(...skipping 688 matching lines...) Expand 10 before | Expand all | Expand 10 after
699 // note is a reminder that eventually "inherit" needs to be supported. 699 // note is a reminder that eventually "inherit" needs to be supported.
700 } 700 }
701 701
702 void StyleBuilderFunctions::applyValueCSSPropertyContent(StyleResolverState& sta te, CSSValue* value) 702 void StyleBuilderFunctions::applyValueCSSPropertyContent(StyleResolverState& sta te, CSSValue* value)
703 { 703 {
704 // list of string, uri, counter, attr, i 704 // list of string, uri, counter, attr, i
705 705
706 bool didSet = false; 706 bool didSet = false;
707 for (auto& item : toCSSValueList(*value)) { 707 for (auto& item : toCSSValueList(*value)) {
708 if (item->isImageGeneratorValue()) { 708 if (item->isImageGeneratorValue()) {
709 state.style()->setContent(StyleGeneratedImage::create(toCSSImageGene ratorValue(*item)), didSet); 709 state.style()->setContent(StyleGeneratedImage::create(toCSSImageGene ratorValue(item.get())), didSet);
710 didSet = true; 710 didSet = true;
711 } else if (item->isImageSetValue()) { 711 } else if (item->isImageSetValue()) {
712 state.style()->setContent(state.elementStyleResources().setOrPending FromValue(CSSPropertyContent, toCSSImageSetValue(*item)), didSet); 712 state.style()->setContent(state.elementStyleResources().setOrPending FromValue(CSSPropertyContent, toCSSImageSetValue(*item)), didSet);
713 didSet = true; 713 didSet = true;
714 } 714 }
715 715
716 if (item->isImageValue()) { 716 if (item->isImageValue()) {
717 state.style()->setContent(state.elementStyleResources().cachedOrPend ingFromValue(state.document(), CSSPropertyContent, toCSSImageValue(*item)), didS et); 717 state.style()->setContent(state.elementStyleResources().cachedOrPend ingFromValue(state.document(), CSSPropertyContent, toCSSImageValue(*item)), didS et);
718 didSet = true; 718 didSet = true;
719 continue; 719 continue;
(...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after
851 return; 851 return;
852 case CSSValueSuper: 852 case CSSValueSuper:
853 svgStyle.setBaselineShift(BS_SUPER); 853 svgStyle.setBaselineShift(BS_SUPER);
854 return; 854 return;
855 default: 855 default:
856 ASSERT_NOT_REACHED(); 856 ASSERT_NOT_REACHED();
857 } 857 }
858 } 858 }
859 859
860 } // namespace blink 860 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698