chrome/installer/util/shell_util.h - Issue 13864015: Move app launcher and chrome apps shortcut strings into the installer

Unified Diff: chrome/installer/util/shell_util.h

Issue 13864015: Move app launcher and chrome apps shortcut strings into the installer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@migrate_app_id_fix

Patch Set: rework Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/installer/util/shell_util.h

diff --git a/chrome/installer/util/shell_util.h b/chrome/installer/util/shell_util.h

index bfdb9b953ecfeec05bd2c918e40e8096246a7b16..50f3d4d103fcd434ea7d8bcf6ff98e74ad19394a 100644

--- a/chrome/installer/util/shell_util.h

+++ b/chrome/installer/util/shell_util.h

@@ -44,6 +44,7 @@ class ShellUtil {

SHORTCUT_LOCATION_DESKTOP,

SHORTCUT_LOCATION_QUICK_LAUNCH,

SHORTCUT_LOCATION_START_MENU,

+ // TODO(mgiuca): add SHORTCUT_LOCATION_START_MENU_CHROME_APPS_DIR here.

gab 2013/04/29 21:34:44 FYI this will conflict with https://codereview.chr

gab 2013/04/29 21:34:44 I don't think a TODO is required here since none o

gab 2013/04/29 21:45:28 Seems indeed that https://codereview.chromium.org/

Matt Giuca 2013/04/30 01:14:09 Hi Gab, Yes, I'm aware of this CL (it was my sugg

gab 2013/04/30 15:00:24 I see, thanks for clarifying, I'd prefer not to ha

};

enum ShortcutOperation {

« chrome/browser/web_applications/web_app_win.cc ('K') | « chrome/browser/web_applications/web_app_win.cc ('k') | no next file » | no next file with comments »