chrome/installer/util/browser_distribution.cc - Issue 13864015: Move app launcher and chrome apps shortcut strings into the installer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/browser_distribution.cc

Issue 13864015: Move app launcher and chrome apps shortcut strings into the installer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@migrate_app_id_fix

Patch Set: fix win compile, change LOG(INFO)s to VLOG(1) Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/installer/util/browser_distribution.cc

diff --git a/chrome/installer/util/browser_distribution.cc b/chrome/installer/util/browser_distribution.cc

index 2456cbdc0c9c3dce431b0dd2a0250e43f9f8a8da..fb3853384ae7a29912f1c8fd5d2848fb62b8fdd2 100644

--- a/chrome/installer/util/browser_distribution.cc

+++ b/chrome/installer/util/browser_distribution.cc

@@ -191,8 +191,13 @@ string16 BrowserDistribution::GetIconFilename() {

string16 BrowserDistribution::GetStartMenuShortcutSubfolder(

Subfolder subfolder_type) {

- DCHECK_EQ(subfolder_type, SUBFOLDER_CHROME);

- return GetShortcutName(SHORTCUT_CHROME);

+ switch (subfolder_type) {

+ case SUBFOLDER_APPS:

+ return installer::GetLocalizedString(IDS_APP_SHORTCUTS_SUBDIR_NAME_BASE);

+ default:

+ DCHECK_EQ(subfolder_type, SUBFOLDER_CHROME);

+ return GetShortcutName(SHORTCUT_CHROME);

+ }

}

string16 BrowserDistribution::GetBaseAppId() {

« no previous file with comments | « chrome/installer/util/browser_distribution.h ('k') | chrome/installer/util/google_chrome_sxs_distribution.h » ('j') | no next file with comments »