Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2146)

Unified Diff: chrome/browser/chrome_browser_main_win.cc

Issue 13864015: Move app launcher and chrome apps shortcut strings into the installer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@migrate_app_id_fix
Patch Set: fix win compile, change LOG(INFO)s to VLOG(1) Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/apps/shortcut_manager.cc ('k') | chrome/browser/shell_integration.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chrome_browser_main_win.cc
diff --git a/chrome/browser/chrome_browser_main_win.cc b/chrome/browser/chrome_browser_main_win.cc
index 52a0785928caa6b8cc80f931e51936bbfb8ec8b9..48696c65c6aa4ed65c8a0a0fd21145b94870f13f 100644
--- a/chrome/browser/chrome_browser_main_win.cc
+++ b/chrome/browser/chrome_browser_main_win.cc
@@ -124,6 +124,8 @@ int DoUninstallTasks(bool chrome_still_running) {
if (result != chrome::RESULT_CODE_UNINSTALL_USER_CANCEL) {
// The following actions are just best effort.
+ // TODO(gab): Look into removing this code which is now redundant with the
+ // work done by setup.exe on uninstall.
VLOG(1) << "Executing uninstall actions";
if (!first_run::RemoveSentinel())
VLOG(1) << "Failed to delete sentinel file.";
@@ -132,7 +134,8 @@ int DoUninstallTasks(bool chrome_still_running) {
ShellUtil::ShortcutLocation user_shortcut_locations[] = {
ShellUtil::SHORTCUT_LOCATION_DESKTOP,
ShellUtil::SHORTCUT_LOCATION_QUICK_LAUNCH,
- ShellUtil::SHORTCUT_LOCATION_START_MENU,
+ ShellUtil::SHORTCUT_LOCATION_START_MENU_CHROME_DIR,
+ ShellUtil::SHORTCUT_LOCATION_START_MENU_CHROME_APPS_DIR,
};
BrowserDistribution* dist = BrowserDistribution::GetDistribution();
for (size_t i = 0; i < arraysize(user_shortcut_locations); ++i) {
« no previous file with comments | « chrome/browser/apps/shortcut_manager.cc ('k') | chrome/browser/shell_integration.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698