Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Unified Diff: runtime/lib/typeddata.dart

Issue 13863012: Refactor List.setRange function. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Rebase Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/lib/typeddata.dart
diff --git a/runtime/lib/typeddata.dart b/runtime/lib/typeddata.dart
index 8bf7a8cf7e2751834ab86947f7a0a5b10ec85be1..ebe0798ccc560b802b2f4ebb2e8b1734012c2e60 100644
--- a/runtime/lib/typeddata.dart
+++ b/runtime/lib/typeddata.dart
@@ -487,10 +487,10 @@ abstract class _TypedListBase {
return IterableMixinWorkaround.getRangeList(this, start, end);
}
- void setRange(int start, int length, List from, [int startFrom = 0]) {
- if (!_setRange(start, length, from, startFrom)) {
+ void setRange(int start, int end, List from, [int startFrom = 0]) {
+ if (!_setRange(start, end - start, from, startFrom)) {
IterableMixinWorkaround.setRangeList(this, start,
- length, from, startFrom);
+ end, from, startFrom);
}
}

Powered by Google App Engine
This is Rietveld 408576698