Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Unified Diff: sdk/lib/html/dartium/html_dartium.dart

Issue 13863012: Refactor List.setRange function. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Handle optional arguments in secure_socket.dart Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: sdk/lib/html/dartium/html_dartium.dart
diff --git a/sdk/lib/html/dartium/html_dartium.dart b/sdk/lib/html/dartium/html_dartium.dart
index 181104f13ff67b94a696042d2709c3df05610922..5b7ae84a18c6ee02717ec132df7f0ec83b97c85a 100644
--- a/sdk/lib/html/dartium/html_dartium.dart
+++ b/sdk/lib/html/dartium/html_dartium.dart
@@ -7552,7 +7552,7 @@ class DomMimeTypeArray extends NativeFieldWrapperClass1 implements List<DomMimeT
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<DomMimeType> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<DomMimeType> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -7828,7 +7828,7 @@ class DomPluginArray extends NativeFieldWrapperClass1 implements List<DomPlugin>
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<DomPlugin> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<DomPlugin> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -8256,7 +8256,7 @@ class DomStringList extends NativeFieldWrapperClass1 implements List<String> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<String> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<String> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -8521,8 +8521,8 @@ class _ChildrenElementList extends ListBase<Element> {
return _childElements.fold(initialValue, combine);
}
- void setRange(int start, int rangeLength, List from,
- [int startFrom = 0]) {
+ void setRange(int start, int end, Iterable<Element> iterable,
+ [int skipCount = 0]) {
throw new UnimplementedError();
}
@@ -8664,8 +8664,8 @@ class _FrozenElementList extends ListBase {
throw new UnsupportedError('');
}
- void setRange(int start, int rangeLength, List from,
- [int startFrom = 0]) {
+ void setRange(int start, int end, Iterable<Element> iterable,
+ [int skipCount = 0]) {
throw new UnsupportedError('');
}
@@ -10927,7 +10927,7 @@ class FileList extends NativeFieldWrapperClass1 implements List<File> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<File> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<File> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -11441,7 +11441,7 @@ class Float32Array extends ArrayBufferView implements List<double> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<num> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<num> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -11684,7 +11684,7 @@ class Float64Array extends ArrayBufferView implements List<double> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<num> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<num> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -12376,7 +12376,7 @@ class HtmlAllCollection extends NativeFieldWrapperClass1 implements List<Node> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<Node> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<Node> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -12593,7 +12593,7 @@ class HtmlCollection extends NativeFieldWrapperClass1 implements List<Node> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<Node> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<Node> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -14966,7 +14966,7 @@ class Int16Array extends ArrayBufferView implements List<int> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<int> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<int> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -15209,7 +15209,7 @@ class Int32Array extends ArrayBufferView implements List<int> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<int> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<int> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -15452,7 +15452,7 @@ class Int8Array extends ArrayBufferView implements List<int> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<int> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<int> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -18189,7 +18189,8 @@ class _ChildNodeListLazy extends ListBase<Node> {
}
// FIXME: implement these.
- void setRange(int start, int rangeLength, List<Node> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<Node> iterable,
+ [int skipCount = 0]) {
throw new UnsupportedError(
"Cannot setRange on immutable List.");
}
@@ -18754,7 +18755,7 @@ class NodeList extends NativeFieldWrapperClass1 implements List<Node> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<Node> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<Node> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -21381,7 +21382,7 @@ class SourceBufferList extends EventTarget implements List<SourceBuffer> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<SourceBuffer> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<SourceBuffer> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -21707,7 +21708,7 @@ class SpeechGrammarList extends NativeFieldWrapperClass1 implements List<SpeechG
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<SpeechGrammar> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<SpeechGrammar> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -23448,7 +23449,7 @@ class TextTrackCueList extends NativeFieldWrapperClass1 implements List<TextTrac
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<TextTrackCue> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<TextTrackCue> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -23665,7 +23666,7 @@ class TextTrackList extends EventTarget implements List<TextTrack> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<TextTrack> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<TextTrack> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -24099,7 +24100,7 @@ class TouchList extends NativeFieldWrapperClass1 implements List<Touch> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<Touch> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<Touch> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -24616,7 +24617,7 @@ class Uint16Array extends ArrayBufferView implements List<int> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<int> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<int> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -24859,7 +24860,7 @@ class Uint32Array extends ArrayBufferView implements List<int> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<int> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<int> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -25102,7 +25103,7 @@ class Uint8Array extends ArrayBufferView implements List<int> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<int> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<int> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -25343,7 +25344,7 @@ class Uint8ClampedArray extends Uint8Array implements List<int> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<int> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<int> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -27449,7 +27450,7 @@ class _ClientRectList extends NativeFieldWrapperClass1 implements List<Rect> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<Rect> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<Rect> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -27671,7 +27672,7 @@ class _CssRuleList extends NativeFieldWrapperClass1 implements List<CssRule> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<CssRule> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<CssRule> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -27880,7 +27881,7 @@ class _CssValueList extends _CSSValue implements List<_CSSValue> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<_CSSValue> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<_CSSValue> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -28325,7 +28326,7 @@ class _EntryArray extends NativeFieldWrapperClass1 implements List<Entry> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<Entry> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<Entry> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -28534,7 +28535,7 @@ class _EntryArraySync extends NativeFieldWrapperClass1 implements List<_EntrySyn
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<_EntrySync> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<_EntrySync> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -28804,7 +28805,7 @@ class _GamepadList extends NativeFieldWrapperClass1 implements List<Gamepad> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<Gamepad> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<Gamepad> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -29104,7 +29105,7 @@ class _NamedNodeMap extends NativeFieldWrapperClass1 implements List<Node> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<Node> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<Node> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -29398,7 +29399,7 @@ class _SpeechInputResultList extends NativeFieldWrapperClass1 implements List<Sp
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<SpeechInputResult> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<SpeechInputResult> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -29607,7 +29608,7 @@ class _SpeechRecognitionResultList extends NativeFieldWrapperClass1 implements L
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<SpeechRecognitionResult> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<SpeechRecognitionResult> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -29816,7 +29817,7 @@ class _StyleSheetList extends NativeFieldWrapperClass1 implements List<StyleShee
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<StyleSheet> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<StyleSheet> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -32399,8 +32400,8 @@ class _WrappedList<E> implements List<E> {
Iterable<E> getRange(int start, int end) => _list.getRange(start, end);
- void setRange(int start, int length, List<E> from, [int startFrom]) {
- _list.setRange(start, length, from, startFrom);
+ void setRange(int start, int end, Iterable<E> iterable, [int skipCount = 0]) {
+ _list.setRange(start, end, iterable, skipCount);
}
void removeRange(int start, int length) { _list.removeRange(start, length); }

Powered by Google App Engine
This is Rietveld 408576698