Issue 13863007: Integrate audio dbus api: GetNodes.

Issue 13863007: Integrate audio dbus api: GetNodes. (Closed)

Created:
7 years, 8 months ago by jennyz

Modified:
7 years, 8 months ago

Reviewers:
stevenjb

CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Integrate audio dbus api: GetNodes and a small improvement to GetVolumeState. BUG=160311 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193484

Patch Set 2 : Fix nit. #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+178 lines, -23 lines)			Patch
M	chromeos/chromeos.gyp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A +	chromeos/dbus/audio_node.h	View		1 chunk	+14 lines, -9 lines	0 comments	Download
A	chromeos/dbus/audio_node.cc	View	1	1 chunk	+42 lines, -0 lines	0 comments	Download
M	chromeos/dbus/cras_audio_client.h	View		2 chunks	+13 lines, -3 lines	0 comments	Download
M	chromeos/dbus/cras_audio_client.cc	View		4 chunks	+106 lines, -11 lines	0 comments	Download
M	chromeos/dbus/mock_cras_audio_client.h	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

jennyz

I left some string constants in cras_audio_client.cc for GetNodes properties, which should be defined on ...

7 years, 8 months ago (2013-04-10 18:50:41 UTC) #1

stevenjb

lgtm https://codereview.chromium.org/13863007/diff/1/chromeos/dbus/audio_node.cc File chromeos/dbus/audio_node.cc (right): https://codereview.chromium.org/13863007/diff/1/chromeos/dbus/audio_node.cc#newcode24 chromeos/dbus/audio_node.cc:24: "id = %" PRIu64" ", nit: no ' ...

7 years, 8 months ago (2013-04-10 20:27:13 UTC) #2

jennyz

https://codereview.chromium.org/13863007/diff/1/chromeos/dbus/audio_node.cc File chromeos/dbus/audio_node.cc (right): https://codereview.chromium.org/13863007/diff/1/chromeos/dbus/audio_node.cc#newcode24 chromeos/dbus/audio_node.cc:24: "id = %" PRIu64" ", On 2013/04/10 20:27:13, stevenjb ...

7 years, 8 months ago (2013-04-10 20:56:28 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jennyz@chromium.org/13863007/5001

7 years, 8 months ago (2013-04-10 20:56:39 UTC) #4

Message was sent while issue was closed.

Change committed as 193484

Expand Messages | Collapse Messages