Add Simple Cache choice to about:flags

Add Simple Cache choice to about:flags

This is done with a multiple choice because later we will add another option:
"choose the cache backend at random", and make it the default.

BUG=173390, 173381
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193396

[rvargas (doing something else), 2013-04-09 19:02:47]

https://codereview.chromium.org/13862014/diff/19/chrome/app/generated_resourc...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/13862014/diff/19/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:14920: +      Enable Simple HTTP Cache.
Warning!!! It may corrupt your cache!! Do not use it!
nit: it is not an http cache

https://codereview.chromium.org/13862014/diff/19/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:14923: +      The Simple HTTP Cache is a new
HTTP cache written from scratch. It prefers to rely on OS filesystem to optimize
disk access.
same here

https://codereview.chromium.org/13862014/diff/19/chrome/browser/about_flags.cc
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/13862014/diff/19/chrome/browser/about_flags.c...
chrome/browser/about_flags.cc:227: const Experiment::Choice
kSimpleCacheBackendChoices[] = {
This should only be there for Android

[gavinp, 2013-04-10 09:54:11]

I'm OK with it being only for Android. iOS doesn't have about:flags, and I guess
we'll wait a bit longer before testing it on ChromeOS.

https://codereview.chromium.org/13862014/diff/19/chrome/app/generated_resourc...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/13862014/diff/19/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:14920: +      Enable Simple HTTP Cache.
Warning!!! It may corrupt your cache!! Do not use it!
On 2013/04/09 19:02:47, rvargas wrote:
> nit: it is not an http cache

Perhaps the best wording is "Simple Cache for HTTP". It's a cache backend, but
backend is a somewhat technical term we don't need to use here. It's only used
for HTTP, so it's probably worth mentioning that protocol.

[gavinp, 2013-04-10 09:56:24]

https://codereview.chromium.org/13862014/diff/19/chrome/app/generated_resourc...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/13862014/diff/19/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:14920: +      Enable Simple HTTP Cache.
Warning!!! It may corrupt your cache!! Do not use it!
Wording suggestion: "Enable Simple Cache for HTTP. Extremely unstable. It will
corrupt your cache. Do not use this option."

https://codereview.chromium.org/13862014/diff/19/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:14923: +      The Simple HTTP Cache is a new
HTTP cache written from scratch. It prefers to rely on OS filesystem to optimize
disk access.
Wording suggestion: "The Simple Cache for HTTP is a new cache for HTTP. It
relies on the filesystem for disk allocation."

[pasko-google - do not use, 2013-04-10 12:56:00]

I updated the wording, not exactly matching the proposed ones, feel free to
correct more.
The flag is now possible to tweak only on Android, on other platforms we can use
the command-line flag, and ChromeOS can wait.

Ready for another look.

[gavinp, 2013-04-10 13:06:10]

LGTM with or without my nits.

https://codereview.chromium.org/13862014/diff/8001/chrome/app/generated_resou...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/13862014/diff/8001/chrome/app/generated_resou...
chrome/app/generated_resources.grd:14925: +      Enable Simple Cache for HTTP.
Unstable! It may corrupt your cache! Do not use this option.
Nit: Enable the Simple Cache for HTTP.

https://codereview.chromium.org/13862014/diff/8001/chrome/browser/about_flags.cc
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/13862014/diff/8001/chrome/browser/about_flags...
chrome/browser/about_flags.cc:1323: }
nit:  },

Always add that final comma.

[pasko-google - do not use, 2013-04-10 13:55:01]

https://codereview.chromium.org/13862014/diff/8001/chrome/app/generated_resou...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/13862014/diff/8001/chrome/app/generated_resou...
chrome/app/generated_resources.grd:14925: +      Enable Simple Cache for HTTP.
Unstable! It may corrupt your cache! Do not use this option.
On 2013/04/10 13:06:10, gavinp wrote:
> Nit: Enable the Simple Cache for HTTP.

Done.

https://codereview.chromium.org/13862014/diff/8001/chrome/browser/about_flags.cc
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/13862014/diff/8001/chrome/browser/about_flags...
chrome/browser/about_flags.cc:1323: }
On 2013/04/10 13:06:10, gavinp wrote:
> nit:  },
> 
> Always add that final comma.

Done.

[commit-bot: I haz the power, 2013-04-10 13:55:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pasko@google.com/13862014/15001

[commit-bot: I haz the power, 2013-04-10 13:55:23]

Failed to apply patch for chrome/browser/about_flags.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/about_flags.cc
  Hunk #1 succeeded at 225 (offset 1 line).
  Hunk #2 FAILED at 1314.
  1 out of 2 hunks FAILED -- saving rejects to file
chrome/browser/about_flags.cc.rej

Patch:       chrome/browser/about_flags.cc
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index
0e87ccf3aad24747016c90631dc95e9b893de46b..086b2f1ed1564b50c73675b2c459444f8161122c
100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -224,6 +224,12 @@ const Experiment::Choice kMaxTilesForInterestAreaChoices[]
= {
     cc::switches::kMaxTilesForInterestArea, "512"}
 };
 
+const Experiment::Choice kSimpleCacheBackendChoices[] = {
+  { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED, "", "off" },
+  { IDS_GENERIC_EXPERIMENT_CHOICE_ENABLED,
+    switches::kUseSimpleCacheBackend, "on"}
+};
+
 // RECORDING USER METRICS FOR FLAGS:
 //
-----------------------------------------------------------------------------
 // The first line of the experiment is the internal name. If you'd like to
@@ -1308,6 +1314,13 @@ const Experiment kExperiments[] = {
     kOsAll,
     SINGLE_VALUE_TYPE(switches::kEnableTranslateAlphaLanguages)
   },
+  {
+    "enable-simple-cache-backend",
+    IDS_FLAGS_ENABLE_SIMPLE_CACHE_BACKEND_NAME,
+    IDS_FLAGS_ENABLE_SIMPLE_CACHE_BACKEND_DESCRIPTION,
+    kOsAndroid,
+    MULTI_VALUE_TYPE(kSimpleCacheBackendChoices)
+  },
 };
 
 const Experiment* experiments = kExperiments;

[commit-bot: I haz the power, 2013-04-10 14:10:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pasko@google.com/13862014/15002

[commit-bot: I haz the power, 2013-04-10 16:42:05]

Change committed as 193396