Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Issue 13862008: Let ComputeTarget fail if it skips over NORMAL objects. (Closed)

Created:
7 years, 8 months ago by Toon Verwaest
Modified:
7 years, 8 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Let ComputeTarget fail if it skips over NORMAL objects. BUG=v8:2595 Committed: https://code.google.com/p/v8/source/detail?r=14190

Patch Set 1 #

Patch Set 2 : Remove duplicate dictionary check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -24 lines) Patch
M src/ast.cc View 1 2 chunks +5 lines, -1 line 0 comments Download
A + test/mjsunit/regress/regress-2595.js View 1 chunk +24 lines, -23 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
7 years, 8 months ago (2013-04-09 14:50:00 UTC) #1
Jakob Kummerow
lgtm
7 years, 8 months ago (2013-04-09 15:14:52 UTC) #2
Toon Verwaest
7 years, 8 months ago (2013-04-09 16:38:59 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r14190 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698