Issue 13861029: Changing type of a widget for notification popups, to remove them from Win taskbar.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13861029: Changing type of a widget for notification popups, to remove them from Win taskbar. (Closed)

Created:
7 years, 8 months ago by Dmitry Titov

Modified:
7 years, 8 months ago

Reviewers:
dewittj

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Changing type of a widget for notification popups, to remove them from Win taskbar. Previous change only affected Notification Center, this one adds popups. Replacing TYPE_WINDOW_FRAMELESS with TYPE_POPUP seems to be equivalent in the context of notifications. On Windows, it adds a WS_EX_TOOLWINDOW style that removes the window from taskbar and Alt-Tab. BUG=223685 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193418

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	ui/message_center/views/message_popup_collection.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dimich@chromium.org/13861029/1

7 years, 8 months ago (2013-04-09 23:56:12 UTC) #3

commit-bot: I haz the power

Step "update" is always a major failure. Look at the try server FAQ for more ...

7 years, 8 months ago (2013-04-10 00:39:21 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dimich@chromium.org/13861029/1

7 years, 8 months ago (2013-04-10 15:42:08 UTC) #5

Message was sent while issue was closed.

Change committed as 193418

Expand Messages | Collapse Messages