Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 13861023: [Android][Reland] Extract signing+zipaligning to python (Closed)

Created:
7 years, 8 months ago by cjhopman
Modified:
7 years, 8 months ago
Reviewers:
Yaron
CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org
Visibility:
Public.

Description

[Android][Reland] Extract signing+zipaligning to python Continued de-antification. This one is pretty straightforward. Landed in https://chromiumcodereview.appspot.com/13427020 Reverted in https://codereview.chromium.org/13866023/ TBR=yfriedman@chromium.org BUG=158821 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193238

Patch Set 1 #

Patch Set 2 : Fix clobber build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -37 lines) Patch
M build/android/ant/apk-package.xml View 3 chunks +2 lines, -34 lines 0 comments Download
A build/android/gyp/finalize_apk.py View 1 chunk +69 lines, -0 lines 0 comments Download
M build/java_apk.gypi View 1 4 chunks +26 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
cjhopman
yfriedman: TBR Patchset 1 is original patch.
7 years, 8 months ago (2013-04-09 20:05:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/13861023/2001
7 years, 8 months ago (2013-04-09 20:05:49 UTC) #2
Yaron
lgtm
7 years, 8 months ago (2013-04-09 20:47:29 UTC) #3
commit-bot: I haz the power
7 years, 8 months ago (2013-04-09 22:22:16 UTC) #4
Message was sent while issue was closed.
Change committed as 193238

Powered by Google App Engine
This is Rietveld 408576698