Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 13861016: CrOS: Look for consistency between successive vsync intervals. (Closed)

Created:
7 years, 8 months ago by jonathan.backer
Modified:
7 years, 8 months ago
Reviewers:
piman
CC:
chromium-reviews
Visibility:
Public.

Description

CrOS: Look for consistency between successive vsync intervals. Currently we report computed vsync intervals based on if they are in an expected range and silently drop otherwise. The disadvantage with this is that we're probably reporting noise caused by configuration changes (monitor reconfiguration or moving a window between monitors). We may also be papering over driver bugs. Instead, we look for consistency between successive computed intervals as a way of validating that there hasn't been a configuration change. In this case, we can be more aggressive in error reporting to find driver bugs (crash instead of silently drop). BUG=221701 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193386

Patch Set 1 : "" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -18 lines) Patch
M ui/gl/vsync_provider.h View 2 chunks +8 lines, -0 lines 0 comments Download
M ui/gl/vsync_provider.cc View 3 chunks +39 lines, -18 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jonathan.backer
I'd like to crash rather than just log with the understanding that I will switch ...
7 years, 8 months ago (2013-04-09 17:44:05 UTC) #1
jonathan.backer
On 2013/04/09 17:44:05, jonathan.backer wrote: > I'd like to crash rather than just log with ...
7 years, 8 months ago (2013-04-09 18:30:35 UTC) #2
piman
LGTM - TBH I'm kinda sad that we need all that logic, and wish we ...
7 years, 8 months ago (2013-04-10 01:17:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/backer@chromium.org/13861016/2001
7 years, 8 months ago (2013-04-10 12:24:06 UTC) #4
commit-bot: I haz the power
7 years, 8 months ago (2013-04-10 15:19:49 UTC) #5
Message was sent while issue was closed.
Change committed as 193386

Powered by Google App Engine
This is Rietveld 408576698